New spec implementation for the cli #174

Merged
merged 19 commits into from Dec 18, 2015

Conversation

Projects
None yet
3 participants
Collaborator

sergiusens commented Dec 18, 2015

This implements the move to the new spec'ed cli, also using docopts instead of argparse.
The integration tests are now also python based instead of using plainbox

sergiusens and others added some commits Nov 30, 2015

cli: Move to docopt, help cmd migrated.
The help command has been migrated. Tests other than unit have
been disabled until the transition is complete.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cli: list-plugins cmd migrated to docopts.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cli: clean cmd migrated to docopts.
This also involved moving `load_config` to the `yaml` module.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cli: init cmd migrated to docopts.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cli: pull command migrated to docopts
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
clean cmd: migrate to use new lifecycle attribs
This also migrates clean to use real elements instead of
over mocking.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Removing dead test code
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cli: build command migrated to docopts
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cli: stage command migrated to docopts
This also introduces recursive lifecycle execution to properly
handle dependencies.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Remove dead code from lifecycle
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cli: strip command migrated to docopts
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Obsolete deprecations from 1.x
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Removing the 'vendor' keyword
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Making the icon optional
The store should provide an icon if it is missing.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cli: snap command migrated to docopts
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Enabling testing with new cli
This inlcudes fixes to how recursion is handled, removes obsolete tests and
does some minor clean ups on some of the code paths that required change to
make them work. The minimum python version has been bumped to 3.5 to match
what is to be released with xenial.

Given the cyclic dep introduced, the PluginHandler and its supporting
functions have been moved to a new snapcraft.pluginhandler module.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Merge pull request #173 from elopio/rerebased_py_integration
Translated the plainbox tests to python.
Member

elopio commented Dec 18, 2015

👍 Merge!
A huge change right at the end of the year, what could possibly go wrong? ^_^.
Next year we can focus on making the coverage more meaningful. For now it's good enough.
I'll let @kyrofa hit the Merge button, so the three of us get an equal share of responsibility when things terribly break ;)

Member

kyrofa commented Dec 18, 2015

Haha, @elopio you suck. Merging!

kyrofa added a commit that referenced this pull request Dec 18, 2015

Merge pull request #174 from ubuntu-core/rebased-new-cli
New spec implementation for the cli

@kyrofa kyrofa merged commit 5e15b30 into master Dec 18, 2015

2 of 3 checks passed

coverage/coveralls Coverage decreased (-7.9%) to 87.969%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sergiusens sergiusens deleted the rebased-new-cli branch Dec 18, 2015

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Merge pull request #174 from ubuntu-core/rebased-new-cli
New spec implementation for the cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment