Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
lxd: add an --image argument to cleanbuild #1769
Conversation
mwhudson
referenced this pull request
Nov 29, 2017
Closed
cleanbuild: add a --image option to build in a different image #1557
kalikiana
self-requested a review
Dec 4, 2017
kalikiana
reviewed
Dec 4, 2017
I notice you didn't update snapcraft/cli/containers.py to make the refresh command use the image as well. And somehow the unit test for it wasn't run. I'll have to investigate what's wrong with the test, it seems it got lost between folder structure changes.
| @@ -50,6 +50,11 @@ def use_container(self): | ||
| def remote(self): | ||
| return self._remote | ||
| + @property | ||
| + def image(self): | ||
| + # TODO: allow this to be overridden |
kalikiana
Dec 4, 2017
Collaborator
It slightly bugs me that now there's two places where the default image is defined... how about putting the default image in snapcraft/internal/common.py?
|
I proposed #1787 to fix the refresh test. |
|
I updated the refresh command now that the test for it fails :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mwhudson commentedNov 29, 2017
A replacement for #1557