/snapcraft

lxd: always install squashfuse #1786

Merged
merged 3 commits into from Dec 19, 2017

Conversation

Reviewers

@elopio elopio

@kyrofa kyrofa

@sergiusens sergiusens

Assignees

@kalikiana kalikiana

Labels
bug
Projects
18.04 (awaiting triage)
Milestone
  2.38
4 participants
@kalikiana @elopio @kyrofa @sergiusens
@kalikiana
Collaborator

kalikiana commented Dec 4, 2017

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

Fixes: bug 730561
snapcraft/internal/lxd/_containerbuild.py
- self._container_run(['apt-get', 'install', 'squashfuse', '-y'])
+ # Because of https://bugs.launchpad.net/snappy/+bug/1628289
+ # Needed to run snapcraft as a snap and build-snaps
+ self._container_run(['apt-get', 'install', 'squashfuse', '-y'])
@elopio

elopio Dec 4, 2017

Member

Now this is not only related to snapcraft. Shouldn't we move it to another function? inject_snapcraft doesn't sound like the right place for this to be.

@kyrofa

kyrofa Dec 4, 2017 •
Edited 1 time

Member

Agreed, we have some sort of setup function, don't we?

@sergiusens

sergiusens Dec 14, 2017

Collaborator

@kyrofa @elopio if you guys are going to make a comment that requires a change mark the PR appropriately.

@kyrofa

kyrofa Dec 15, 2017

Member

I think we both just wanted to hear justification for putting it here, not necessarily requiring a change.

@kalikiana

kalikiana Dec 19, 2017

Collaborator

I moved it to the respective container creation code paths of the two classes now.

@sergiusens

sergiusens approved these changes Dec 19, 2017
View changes

I am good with this, for next time thought reference bugs with their easier to read qualifier LP: #1628289

@sergiusens sergiusens merged commit 8ada2f0 into snapcore:master Dec 19, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sergiusens sergiusens assigned kalikiana Dec 19, 2017

@sergiusens sergiusens added this to the 2.38 milestone Dec 19, 2017

@sergiusens sergiusens added the bug label Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment