/snapcraft

Add type hints cli/assertions.py module #1811

Merged
merged 2 commits into from Jan 5, 2018

Conversation

Reviewers

@elopio elopio

@kyrofa kyrofa

Assignees
No one assigned
Labels
codein
Projects
18.04 (awaiting triage)
Milestone
  2.39
4 participants
@m4sk1n @elopio @kyrofa @sergiusens
@m4sk1n
Contributor

m4sk1n commented Dec 16, 2017 •
Edited 1 time

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

@sergiusens sergiusens added the codein label Dec 18, 2017

@m4sk1n m4sk1n changed the title from Add type hints for some modules to Add type hints cli/assertions.py module Dec 28, 2017

@m4sk1n
Add type hint for cli/assertions.py module 
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
209f40d
@kyrofa

kyrofa approved these changes Dec 30, 2017
View changes

Excellent work, @m4sk1n! We'll also need a review from someone more familiar with this module to ensure these types are correct, but they look good to me.

@sergiusens
Merge branch 'master' into typehints
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ddb1bcb
@elopio

elopio approved these changes Jan 5, 2018
View changes

looks good to me too. Thanks!

@sergiusens sergiusens added this to the 2.39 milestone Jan 5, 2018

@sergiusens sergiusens merged commit 5c971be into snapcore:master Jan 5, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment