/snapcraft

Replace use of `assert_not_called` in the catkin tests #200

Merged
merged 1 commit into from Jan 5, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Jan 5, 2016

Mocks using assert_not_called don't take a message, to keep the message
we use assertFalse and the called attribute of the mock.
@sergiusens
Replace use of `assert_not_called` in the catkin tests 
Mocks using `assert_not_called` don't take a message, to keep the message
we use `assertFalse` and the `called` attribute of the mock.

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 88.736%
Details
50b9537
@kyrofa
Member

kyrofa commented Jan 5, 2016

Thanks @sergiusens! Looks great. I'll just wait for Travis to finish.

kyrofa added a commit that referenced this pull request Jan 5, 2016

@kyrofa
Merge pull request #200 from sergiusens/mock-assert-fix 
Replace use of `assert_not_called` in the catkin tests
9c5b834

@kyrofa kyrofa merged commit 9c5b834 into snapcore:master Jan 5, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.736%
Details

@kyrofa kyrofa referenced this pull request Jan 11, 2016

Merged

Backport to 1.x: Replace use of `assert_not_called` in the catkin tests #219

@sergiusens sergiusens deleted the sergiusens:mock-assert-fix branch Mar 1, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@brendandixon
Merge pull request #200 from brendandixon/2.1_selfupdate 
Separate provision agent and guest agent
cd2b018

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@kyrofa
Merge pull request #200 from sergiusens/mock-assert-fix 
Replace use of `assert_not_called` in the catkin tests
a8830cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment