Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Autotools plugin: Set autogen.sh executable. #206
Conversation
kyrofa
referenced this pull request
Jan 6, 2016
Merged
Update debian/changelog for the 1.0 release. #198
sergiusens
reviewed
Jan 7, 2016
| @@ -0,0 +1,155 @@ | ||
| +# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*- | ||
| +# | ||
| +# Copyright (C) 2015 Canonical Ltd |
sergiusens
reviewed
Jan 7, 2016
| + def test_schema(self): | ||
| + schema = autotools.AutotoolsPlugin.schema() | ||
| + | ||
| + # Check rosdistro property |
sergiusens
reviewed
Jan 7, 2016
| + 'DESTDIR={}'.format(plugin.installdir)]) | ||
| + ]) | ||
| + | ||
| + @mock.patch('os.chmod') |
sergiusens
Jan 7, 2016
Collaborator
why are you mocking os.chmod but actually creating the file?
It seems less error prone to not mock os.chmod and os.stat it
kyrofa
Jan 7, 2016
Member
Actually I think I found something even better-- test exactly what I'm trying to do: make autogen.sh runnable.
|
@sergiusens Alright I believe I've addressed your concerns here. |
sergiusens
reviewed
Jan 7, 2016
| + patcher.start() | ||
| + return output | ||
| + | ||
| + return None |
sergiusens
Jan 7, 2016
Collaborator
maybe remove this statement
In [1]: def a():
...: pass
...:
In [2]: a() is None
Out[2]: True
or return '' so it is consistent with what I believe output is (str)
|
|
added a commit
that referenced
this pull request
Jan 7, 2016
sergiusens
merged commit 209a587
into
snapcore:master
Jan 7, 2016
kyrofa
deleted the
kyrofa:bugfix/1530995/executable_autogen
branch
Jan 7, 2016
kyrofa
referenced this pull request
Jan 7, 2016
Merged
Backport to 1.x: Autotools plugin: Set autogen.sh executable. #208
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kyrofa commentedJan 6, 2016
This PR fixes LP: #1530995 by setting autogen.sh to be executable (if necessary). It also adds tests for the autotools plugin.
It will need to be backported to 1.x when approved.