Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update CONTRIBUTING.md to require a bug. #211
Conversation
elopio
reviewed
Jan 8, 2016
| -3. Squash commits into one, well-formatted commit. | ||
| +3. Squash commits into one, well-formatted commit. Mention the bug being | ||
| + resolved in the commit message on a line all by itself like `LP: #<bug>`. |
kyrofa
Jan 8, 2016
Member
You mean only in the PR instead of the commit? If so, no-- the tools we use for changelog generation parse the commit logs, not the PR descriptions.
kyrofa
Jan 8, 2016
Member
If you mean adding a link to the commit, that also doesn't work since git-dch parses for the LP: #<bug> pattern, which a link wouldn't match.
|
|
|
|
|
Agreed. Let's merge this, and if the lack of links becomes painful we can revamp. |
added a commit
that referenced
this pull request
Jan 8, 2016
kyrofa
merged commit ab5dc72
into
snapcore:master
Jan 8, 2016
kyrofa
deleted the
kyrofa:contributing_require_bug
branch
Jan 8, 2016
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kyrofa commentedJan 8, 2016
This PR resolves LP: #1532195 by making the first step of the contribution guidelines "Make sure there's a bug."