/snapcraft

Ensure rosdep resolves dependencies using Trusty. #212

Merged
merged 1 commit into from Jan 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kyrofa @sergiusens @elopio
@kyrofa
Member

kyrofa commented Jan 8, 2016

This PR fixes LP: #1532241 by instructing rosdep to resolve dependencies using Trusty, even if Snapcraft is not being run on Trusty.

This will need to be cherry-picked to 1.x as well.
@kyrofa
Ensure rosdep resolves dependencies using Trusty. 
Without this commit, ROS Indigo packages cannot be built with
Snapcraft installed on versions of Ubuntu later than Trusty.

LP: #1532241

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 89.756%
Details
b74315e

@kyrofa kyrofa referenced this pull request Jan 8, 2016

Merged

Backport to 1.x: Ensure rosdep resolves dependencies using Trusty. #213

@sergiusens
Collaborator

sergiusens commented Jan 8, 2016

👍 but I would like to test on xenial as well (the resulting snap), if @elopio tests it, then I'm good for merge
@elopio
Member

elopio commented Jan 8, 2016

Tested in xenial:
It builds: Snapped ros-example_1.0_amd64.snap
Installing on rolling edge #310 works, but when I run the binaries I get python not found, rosrun not found, cat not found.
@kyrofa
Member

kyrofa commented Jan 8, 2016

Yeah we're probably going to run into other issues with rolling as well. This is verified to at least work on 15.04, built from trusty and xenial, so we'll roll with it.

kyrofa added a commit that referenced this pull request Jan 8, 2016

@kyrofa
Merge pull request #212 from kyrofa/bugfix/1532241/catkin_build_past_… 
…trusty

Ensure rosdep resolves dependencies using Trusty.
3b8fd95

@kyrofa kyrofa merged commit 3b8fd95 into snapcore:master Jan 8, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 89.756%
Details

@kyrofa kyrofa deleted the kyrofa:bugfix/1532241/catkin_build_past_trusty branch Jan 8, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@kyrofa
Merge pull request #212 from kyrofa/bugfix/1532241/catkin_build_past_… 
…trusty

Ensure rosdep resolves dependencies using Trusty.
9fab7f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment