Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Support the new security-override semantics #222
Conversation
kyrofa
reviewed
Jan 12, 2016
| + type: string | ||
| + abstractions: | ||
| + type: array | ||
| + description: a list of additional Apparmor abstractions for the app. |
kyrofa
reviewed
Jan 12, 2016
| + 'apparmor': 'file.apparmor', | ||
| + }, | ||
| + }, | ||
| + } |
sergiusens
Jan 12, 2016
Collaborator
what combos? with subTest I cover
- all
caps&security-policysecurity-override&security-policysecurity-override&caps
kyrofa
Jan 12, 2016
Member
Ah, I read too quickly. However, I can break your code above by removing all but one invalid combo and this test would still pass, correct? Should you be explicitly testing each invalid combination rather than throwing them all together?
kyrofa
Jan 12, 2016
Member
Ah, I missed the deletion below. You do exactly as I ask, just by altering the app on the fly a few times. It could be a bit clearer, but I'm fine with this.
|
Couple nits, but overall looks good. |
jdstrand
reviewed
Jan 12, 2016
| + minItems: 1 | ||
| + uniqueItems: true | ||
| + items: | ||
| + type: string | ||
jdstrand
Jan 12, 2016
You added caps, security-override and security-policy but left out security-template. Since you seem to be going for completeness of the current implementation, you should include security-template. It is of type string. It may be used with caps and security-override, but not security-policy.
added a commit
that referenced
this pull request
Jan 12, 2016
sergiusens
merged commit b36c094
into
snapcore:master
Jan 12, 2016
sergiusens
deleted the
sergiusens:security-override
branch
Jan 12, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
sergiusens commentedJan 12, 2016
LP: #1533293