/snapcraft

Fix catkin plugin python calls #230

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Jan 14, 2016

10.ros.sh which is sourced with setup.sh has a hardcoded
/usr/bin/python which needs to adapt to use the snaps
python interpreter.

LP: #1533297
@sergiusens
Collaborator

sergiusens commented Jan 14, 2016

I now get

[rosrun] Couldn't find executable named listener below /snaps/ros-example.sideload/IKKNUNfbERGD/opt/ros/indigo/share/beginner_tutorials

Maybe we can fix that here too
snapcraft/tests/test_plugin_catkin.py
+ self.assertEqual(f.read(), '#!/usr/bin/env python',
+ 'The shebang was not replaced as expected')
+
+ # Verify that _setup_util.py had its shebang rewritten correctly
@kyrofa

kyrofa Jan 14, 2016

Member

Copy-paste in the comment.

@kyrofa
Member

kyrofa commented Jan 14, 2016

Small comment issue, but otherwise 👍 from me.
@sergiusens
Fix catkin plugin python calls 
10.ros.sh which is sourced with setup.sh has a hardcoded
/usr/bin/python which needs to adapt to use the snaps
python interpreter.

LP: #1533297

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 90.625%
Details
920521d
@kyrofa
Member

kyrofa commented Jan 14, 2016

Alright I'm good merging this as-is, since it fixes an obvious problem. However, I'm also good waiting to see if we can completely fix the bug.
@kyrofa
Member

kyrofa commented Jan 14, 2016

Hey wait... am I missing something? My 10.ros.sh doesn't have a shebang at all. It just directly calls out to /usr/bin/python. Still fixable in a similar manner, but not a shebang.
@sergiusens
Collaborator

sergiusens commented Jan 14, 2016

I'm closing this for now so it doesn't accidentally merge, @kyrofa said he'd take a look.

@sergiusens sergiusens closed this Jan 14, 2016

@sergiusens sergiusens deleted the sergiusens:rosrun-fix branch Mar 1, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@ahmetb @hglkrijger
[2.1] Systemd unit file updates (#230) 
* Rename systemd unit file, chmod -x

* Extend the systemd unit file

* Add notice for ubuntu systemd file
5645bdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment