/snapcraft

Wrap apps with the app name #231

Merged
merged 1 commit into from Jan 15, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @kyrofa @elopio
@sergiusens
Collaborator

sergiusens commented Jan 14, 2016

We wrap with the app name as the params are now globbed into the
wrapper

LP: #1534150
snapcraft/tests/test_meta.py
+
+ relative_exe_path = 'test_relexepath'
+ with open(os.path.join(snapdir, relative_exe_path), 'w'):
+ pass
@kyrofa

kyrofa Jan 14, 2016

Member

Is this better than open(os.path.join(snapdir, relative_exe_path), 'w').close()?

@sergiusens

sergiusens Jan 15, 2016

Collaborator

no it's not, I'll fix this in this test and the test I copied from, thanks for spotting this!

@kyrofa
Member

kyrofa commented Jan 14, 2016

Small ignorable comment-- looks good to me.
@elopio
Member

elopio commented Jan 14, 2016

lgtm.
I want to get all merged to easily try all the binaries.
@sergiusens
Wrap apps with the app name 
We wrap with the app name as the params are now globbed into the
wrapper

LP: #1534150

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.03%) to 90.638%
Details
d132dfd

sergiusens added a commit that referenced this pull request Jan 15, 2016

@sergiusens
Merge pull request #231 from sergiusens/wrapping_for_apps 
Wrap apps with the app name
ef201fe

@sergiusens sergiusens merged commit ef201fe into snapcore:master Jan 15, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 90.638%
Details

@sergiusens sergiusens deleted the sergiusens:wrapping_for_apps branch Jan 15, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #231 from sergiusens/wrapping_for_apps 
Wrap apps with the app name
c899218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment