added test for git sources in sources.py

[fazerlicourice7]

No description provided.

[sergiusens]

called once with what?

[sergiusens]

Looks good, just fix that assertion in the code.

After fixing, do this:

git add snapcraft/tests/test_sources.py 
git commit --ammend
git push [origin|fazer] --force

When ammending add this at the end in one line only:

LP: #XXXXX

Where XXXXX is the launchpad bug number

origin or fazer or whatever your remote is (however you originally ran git push [something])

[fazerlicourice7]

It isn't called with anything: https://github.com/ubuntu-core/snapcraft/blob/master/snapcraft/sources.py#L271

[sergiusens]

@fazerlicourice7 I actually meant amend, but it was considering you'd fix the assertion 😉

[fazerlicourice7]

sergiusens, But there isn't anything to fix. That method 'pull()' isn't called with any parameters.

[sergiusens]

On Thu, Jan 14, 2016 at 11:12 PM, Fazer notifications@github.com wrote:

sergiusens, But there isn't anything to fix. That method 'pull()' isn't
called with any parameters.

Ah, then it is all good. I'm 👍 but @elopio has the final say.

[elopio]

Awesome. Take a look now that we hit the line we were missing:
https://coveralls.io/files/1827079269#L298

[sergiusens]

Just wanted to come back to this PR and say thank you!

[fazerlicourice7]

@elopio can you approve the task on GCI please?