/snapcraft

Replace SNAP envvars with the 16.04 ones. #234

Merged
merged 1 commit into from Jan 15, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @elopio @mvo5
@sergiusens
Collaborator

sergiusens commented Jan 15, 2016

LP: #1533552
@sergiusens
Replace SNAP envvars with the 16.04 ones. 
LP: #1533552

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 90.251%
Details
04b1a13
@elopio
Member

elopio commented Jan 15, 2016

👍, waiting for the tests to confirm.
@mvo5
Contributor

mvo5 commented Jan 15, 2016

Looks good!
@sergiusens
Collaborator

sergiusens commented Jan 15, 2016

Ran 13 tests in 1949.178s
OK

Name Stmts Miss Cover

Run 'python3-coverage html' to get a nice report
View it by running 'x-www-browser htmlcov'

Everything passed

For examples with install logic

sergiusens added a commit that referenced this pull request Jan 15, 2016

@sergiusens
Merge pull request #234 from sergiusens/bugfix/1533552/new-envvars 
Replace SNAP envvars with the 16.04 ones.
82a8a46

@sergiusens sergiusens merged commit 82a8a46 into snapcore:master Jan 15, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.251%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1533552/new-envvars branch Jan 15, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #234 from sergiusens/bugfix/1533552/new-envvars 
Replace SNAP envvars with the 16.04 ones.
e033aca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment