Initialize CMAKE_PREFIX_PATH to [] for ros #240

Merged
merged 1 commit into from Jan 18, 2016

Conversation

Projects
None yet
2 participants
Collaborator

sergiusens commented Jan 18, 2016

The ros plugins are setting _setup_util.py's CMAKE_PREFIX_PATH to
build time paths and later inserting the current path. This fails on
runtime due to confinement as the directories accessed don't exist.
(this is the case for armhf).

LP: #1535309

Initialize CMAKE_PREFIX_PATH to [] for ros
The ros plugins are setting _setup_util.py's CMAKE_PREFIX_PATH to
build time paths and later inserting the current path. This fails on
runtime due to confinement as the directories accessed don't exist.
(this is the case for armhf).

LP: #1535309
Member

kyrofa commented Jan 18, 2016

I don't see the harm in this change, though I'm confused as to why this bites us on arm and not anything else. Access will obviously be denied regardless of the arch. But if it works, 👍 !

sergiusens added a commit that referenced this pull request Jan 18, 2016

Merge pull request #240 from sergiusens/bugfix/1535309/CMAKE_PREFIX_P…
…ATH-arrangements

Initialize CMAKE_PREFIX_PATH to [] for ros

@sergiusens sergiusens merged commit c055cfa into snapcore:master Jan 18, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.1%) to 90.483%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1535309/CMAKE_PREFIX_PATH-arrangements branch Jan 18, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Merge pull request #240 from sergiusens/bugfix/1535309/CMAKE_PREFIX_P…
…ATH-arrangements

Initialize CMAKE_PREFIX_PATH to [] for ros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment