add short plugins docs, stolen from 15.04 appdev manual #241

Merged
merged 1 commit into from Jan 20, 2016

Conversation

Projects
None yet
3 participants
Contributor

dholbach commented Jan 19, 2016

No description provided.

docs/plugins.md
+Is Snapcraft missing support for your preferred build-system? Here's how you
+would add it!
+
+Snapcraft is extensible via plugins adding new part plugins. Let's add
@elopio

elopio Jan 19, 2016

Member

"via plugins adding new part plugins"
That sounds weird.

docs/plugins.md
+import snapcraft
+
+class XCraftyPlugin(snapcraft.BasePlugin):
+ def build(self):
@elopio

elopio Jan 19, 2016

Member

one empty line after the class definition please.

Member

elopio commented Jan 19, 2016

lgtm. I've never tried this, but I've seen tests for this functionality. I will give it a try this week.

Member

kyrofa commented Jan 19, 2016

Thanks @dholbach, very useful addition! Other than @elopio's comments, looks good to me as well.

Member

kyrofa commented Jan 19, 2016

@dholbach sorry to be a bother, but can you please put the LP bug reference in the commit message on its own line, with no parentheses? Automated tools pull those out.

Contributor

dholbach commented Jan 19, 2016

Updated.

Member

kyrofa commented Jan 19, 2016

@elopio's comments still apply.

Add documentation about writing your own plugins.
LP: #1535897

fix wording, thanks Leo
Member

elopio commented Jan 20, 2016

Too much talk, lets land :D
Thanks @dholbach.

elopio added a commit that referenced this pull request Jan 20, 2016

Merge pull request #241 from dholbach/add-plugins-doc
Add documentation about writing your own plugins.

LP: #1535897

@elopio elopio merged commit faee100 into snapcore:master Jan 20, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.0%) to 90.483%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dholbach dholbach deleted the dholbach:add-plugins-doc branch Jan 22, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Merge pull request #241 from dholbach/add-plugins-doc
Add documentation about writing your own plugins.

LP: #1535897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment