Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
repo,baseplugin: support trusting repo keys #2437
Today, snapcraft allows insecure repositories (i.e. repos without a key) because that is the default behavior in Xenial (core16). This behavior changed in Zesty, and stays changed in Bionic (core18). This PR resolves LP: #1811304 by adding the ability to trust keys to the plugin API, taking advantage of it in the Catkin plugin, and flipping the switch to only allow snapcraft to use secure repositories.
@@ Coverage Diff @@ ## master #2437 +/- ## ========================================= Coverage ? 90.03% ========================================= Files ? 196 Lines ? 12959 Branches ? 1966 ========================================= Hits ? 11668 Misses ? 889 Partials ? 402