Added a unit tests for pulling bazaar sources from URIs. #245

Merged
merged 1 commit into from Jan 20, 2016

Conversation

Projects
None yet
3 participants
Contributor

fazerlicourice7 commented Jan 20, 2016

I created a test for bazaar type sources. The test ensures that sources.py correctly recognizes and calls the correct methods for bazaar sources.

LP: #1536283

debian/changelog
@@ -86,6 +86,7 @@ snapcraft (2.0) xenial; urgency=medium
[ Vamshi Balanaga ]
* Added test for git sources in sources.py (LP: #1534411)
+ * Added test for bzr sources in sources.py (LP: #1536283)
@elopio

elopio Jan 20, 2016

Member

You shouldn't edit the changelog of the released version.
We could open a new section for the unreleased 2.1 version, but we are currently trying to do that automatically with git-buildpackage, so just remove this line, please.

Member

elopio commented Jan 20, 2016

The test looks good to me. I will let @kyrofa help you with the squash, because I might just make things worst.
Once you are able to rewrite the commit, please make sure to write it something like this:

Added a unit tests for pulling bazaar sources from URIs.

LP: #1536283

(note the capital letter at the start, and the period at the end. And it's not necessary to mention the file you changed but I consider it good to give a little more context of what you are doing)
We are taking care a lot about commit messages now because we are trying to autogenerate the changelog from them.

Thanks again @fazerlicourice7!

@fazerlicourice7 fazerlicourice7 changed the title from added test for bazaar sources in test_sources.py to Added a unit tests for pulling bazaar sources from URIs. (LP: #1536283) Jan 20, 2016

@kyrofa kyrofa changed the title from Added a unit tests for pulling bazaar sources from URIs. (LP: #1536283) to Added a unit tests for pulling bazaar sources from URIs. Jan 20, 2016

Member

kyrofa commented Jan 20, 2016

Looks good, though since the PR title turns into the merge commit message, let's leave it clean and leave off the bug ref there (just in the PR description and commit message is perfect). I fixed this one.

kyrofa added a commit that referenced this pull request Jan 20, 2016

Merge pull request #245 from fazerlicourice7/create-test-for-bzr-sources
Added a unit tests for pulling bazaar sources from URIs.

@kyrofa kyrofa merged commit 52dfd7d into snapcore:master Jan 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 90.522%
Details
Contributor

fazerlicourice7 commented Jan 20, 2016

Thanks.

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

Merge pull request #245 from fazerlicourice7/create-test-for-bzr-sources
Added a unit tests for pulling bazaar sources from URIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment