/snapcraft

Add build-package description to docs/snapcraft-sytax.md #246

Merged
merged 1 commit into from Jan 21, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kyrofa @elopio
@kyrofa
Member

kyrofa commented Jan 21, 2016

This PR resolves LP: #1536659 by adding a description of build-packages to docs/snapcraft-syntax.md.

@kyrofa kyrofa changed the title from docs/snapcraft-sytax.md needs to include build-packages. to Add build-package description to docs/snapcraft-sytax.md Jan 21, 2016

docs/snapcraft-syntax.md
+ A list of Ubuntu packages to use that would support the part creation.
+ * `build-packages` (list of strings)
+ A list of Ubuntu packages to be installed on the host to aid in building
+ the part but not going into the final snap.
@elopio

elopio Jan 21, 2016

Member

I think this sentence is a little to long. Maybe a period after "to aid in building the part", and "These packages will not go into the final snap." as a separate sentence.

@kyrofa

kyrofa Jan 21, 2016

Member

Agreed. Fixed here and from where I stole it ;) .

@elopio
Member

elopio commented Jan 21, 2016

👍 just one suggestion to split the sentence added.
@kyrofa
Add build-package description to docs/snapcraft-sytax.md 
Currently docs/snapcraft-syntax.md only discusses stage-packages,
which makes it difficult to determine what build-packages does.

LP: #1536659

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

Some checks were not successful

1 failing and 1 successful checks
coverage/coveralls — Coverage decreased (-0.0%) to 90.522%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
ecd6b68
@kyrofa
Member

kyrofa commented Jan 21, 2016

Fixed, thanks @elopio!

@kyrofa kyrofa referenced this pull request Jan 21, 2016

Merged

Backport to 1.x: Add build-package description to docs/snapcraft-sytax.md #247

kyrofa added a commit that referenced this pull request Jan 21, 2016

@kyrofa
Merge pull request #246 from kyrofa/bugfix/1536659/mention_build_pack… 
…ages_in_docs

Add build-package description to docs/snapcraft-sytax.md
4999cfe

@kyrofa kyrofa merged commit 4999cfe into snapcore:master Jan 21, 2016
1 of 2 checks passed

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.0%) to 90.522%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kyrofa kyrofa deleted the kyrofa:bugfix/1536659/mention_build_packages_in_docs branch Jan 21, 2016

@kyrofa kyrofa referenced this pull request Jan 21, 2016

Closed

Fix list indentation in snapcraft-syntax.md. LP: #1531200 #218

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@kyrofa
Merge pull request #246 from kyrofa/bugfix/1536659/mention_build_pack… 
…ages_in_docs

Add build-package description to docs/snapcraft-sytax.md
5a04cc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment