/snapcraft

Autotools plugin: Call make before make install #253

Merged
merged 1 commit into from Jan 23, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kyrofa @elopio
@kyrofa
Member

kyrofa commented Jan 22, 2016

This PR resolves LP: #1536700 by making the Autotools plugin call make before it calls make install.
@kyrofa
Autotools plugin: Call make before make install 
LP: #1536700

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.002%) to 90.524%
Details
bc22131
@elopio
Member

elopio commented Jan 22, 2016

ok. I think it's not worth it to make an integration or example test just for this change.
But it would be nice to have an integration one that requires all the steps of make. We can check about this next week
👍
@kyrofa
Member

kyrofa commented Jan 23, 2016

@elopio sounds good, I think we can swing that. I don't think it would make the greatest example, though-- so probably just an integration test.

kyrofa added a commit that referenced this pull request Jan 23, 2016

@kyrofa
Merge pull request #253 from kyrofa/bugfix/1536700/autotools_call_make 
Autotools plugin: Call make before make install
e09cdb5

@kyrofa kyrofa merged commit e09cdb5 into snapcore:master Jan 23, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 90.524%
Details

@kyrofa kyrofa deleted the kyrofa:bugfix/1536700/autotools_call_make branch Jan 23, 2016

@kyrofa kyrofa referenced this pull request Jan 23, 2016

Merged

Backport to 1.x: Autotools plugin: Call make before make install #254

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@ahmetb @hglkrijger
Add CoC notice (#253) 
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
8576c03

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@kyrofa
Merge pull request #253 from kyrofa/bugfix/1536700/autotools_call_make 
Autotools plugin: Call make before make install
53ed6a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment