Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
make sure that version is set correctly no matter what (version for 2… #256
Conversation
kyrofa
reviewed
Jan 25, 2016
| + head = codecs.open(changelog, encoding='utf-8').readline() | ||
| + match = re.compile('.*\((.*)\).*').match(head) | ||
| + if match: | ||
| + version = match.group(1) |
kyrofa
Jan 25, 2016
Member
I know the possibility of this happening is small, but should version default to 'devel' so if this fails there's still a valid version? Or toss an error? Excellent change here.
|
This looks excellent, thank you! |
added a commit
that referenced
this pull request
Jan 26, 2016
kyrofa
merged commit 21cc74f
into
snapcore:master
Jan 26, 2016
dholbach
deleted the
dholbach:auto-update-version-in-setup.py
branch
Jan 26, 2016
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dholbach commentedJan 25, 2016
….0.1 release was '2.0')
LP: #1537580