/snapcraft

Make plugin: Support non-standard makefile name. #264

Merged
merged 1 commit into from Jan 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kyrofa @elopio
@kyrofa
Member

kyrofa commented Jan 26, 2016

This PR fixes LP: #1500759 by adding a "makefile" property to the Make plugin, which, if specified, results in a make -f <makefile> instead of just make. This supports projects with makefiles named e.g. makefile.linux, etc.
@elopio
Member

elopio commented Jan 26, 2016

👍
An integration tests without the mocks wouldn't hurt :)
@kyrofa
Member

kyrofa commented Jan 26, 2016

@elopio good idea-- done.
@kyrofa
Make plugin: Support non-standard makefile name. 
This commit adds a "makefile" property to the Make plugin, which,
if specified, results in a `make -f <makefile>` instead of just
`make`. This supports projects with makefiles named e.g.
makefile.linux, etc.

LP: #1500759

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.08%) to 91.318%
Details
ef982f2

kyrofa added a commit that referenced this pull request Jan 26, 2016

@kyrofa
Merge pull request #264 from kyrofa/bugfix/1500759/make_plugin_overri… 
…de_makefile

Make plugin: Support non-standard makefile name.
5031c11

@kyrofa kyrofa merged commit 5031c11 into snapcore:master Jan 26, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 91.318%
Details

@kyrofa kyrofa deleted the kyrofa:bugfix/1500759/make_plugin_override_makefile branch Jan 26, 2016

@kyrofa kyrofa referenced this pull request Jan 26, 2016

Merged

Backport to 1.x: Make plugin: Support non-standard makefile name. #265

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@hglkrijger
Remove call to grep (#264) 
* pep8 formatting

* ignore the return code for grep check

* code review feedback
d074b66

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@kyrofa
Merge pull request #264 from kyrofa/bugfix/1500759/make_plugin_overri… 
…de_makefile

Make plugin: Support non-standard makefile name.
731dc8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment