Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colcon plugin: add ability to ignore packages #2687

Merged
merged 4 commits into from Sep 4, 2019

Conversation

@kyrofa
Copy link
Member

commented Aug 26, 2019

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Currently the colcon plugin has the ability to build only a few packages in a given workspace, or build the entire workspace. However, it's not unusual to have only a few packages that don't build properly in the snap. Add the ability to specify packages that should be ignored in the workspace.

Currently the colcon plugin has the ability to build only a few packages
in a given workspace, or build the entire workspace. However, it's not
unusual to have only a few packages that don't build properly in the
snap. Add the ability to specify packages that should be ignored in the
workspace.

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa referenced this pull request Aug 26, 2019
4 of 4 tasks complete
@cjp256
cjp256 approved these changes Aug 28, 2019
Copy link
Collaborator

left a comment

lgtm, but static tests fail;
./tests/unit/plugins/test_colcon.py:1027:5: C901 'BuildTestCase.test_build' is too complex (11)

kyrofa added 2 commits Aug 30, 2019
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Fixed static.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 3, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@dce92d9). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2687   +/-   ##
=========================================
  Coverage          ?   88.76%           
=========================================
  Files             ?      211           
  Lines             ?    14453           
  Branches          ?     2188           
=========================================
  Hits              ?    12829           
  Misses            ?     1170           
  Partials          ?      454
Impacted Files Coverage Δ
snapcraft/plugins/colcon.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce92d9...457c201. Read the comment docs.

@sergiusens sergiusens merged commit bdc2150 into snapcore:master Sep 4, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.