Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: take no command-chain being prepended into account #2731

Merged
merged 1 commit into from Sep 26, 2019

Conversation

sergiusens
Copy link
Collaborator

Avoid an empty command-chain in the apps entry from being set
as a result of using classic confinement for which snapcraft's
core does not prepend its own command-chain.

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Avoid an empty command-chain in the apps entry from being set
as a result of using classic confinement for which snapcraft's
core does not prepend its own command-chain.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll have to rebase on this for #2709.

@sergiusens sergiusens merged commit 3672b4a into canonical:master Sep 26, 2019
@sergiusens sergiusens deleted the command-chain-classic branch September 26, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants