/snapcraft

make sure otp is included in login request only if it's not empty #274

Merged
merged 1 commit into from Jan 28, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ricardokirkner @kyrofa
@ricardokirkner
Contributor

ricardokirkner commented Jan 28, 2016

LP: #1539208
@kyrofa
Member

kyrofa commented Jan 28, 2016

Thanks @ricardokirkner! Looks good to me, just waiting on the tools. Mind also adding a # to the bug reference in the commit message?
@ricardokirkner
make sure otp is included in login request only if it's not empty 
LP: #1539208

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.007%) to 93.269%
Details
cd3f46a

kyrofa added a commit that referenced this pull request Jan 28, 2016

@kyrofa
Merge pull request #274 from ricardokirkner/fix-sso-login-without-otp 
Make sure otp is included in login request only if it's not empty
1fc4fdf

@kyrofa kyrofa merged commit 1fc4fdf into snapcore:master Jan 28, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 93.269%
Details

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@brendandixon
Merge pull request #274 from brendandixon/nobuffer 
Improved download process and ensured output is not buffered
387a7b7

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@kyrofa
Merge pull request #274 from ricardokirkner/fix-sso-login-without-otp 
Make sure otp is included in login request only if it's not empty
9531bfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment