Add documentation for how to use snapcraft upload.

[kyrofa]

This PR resolves LP: #1539234 by adding a document that walks a developer through uploading a snap.

[ricardokirkner]

If we're considering documenting these environment variables, maybe it's best to just export a single variable to control whether STAGING or PRODUCTION is to be used to make developers life easier? (and we set the proper values based on that env var of flag internally).

[kyrofa]

Not a bad idea. I'm not sure how often this will be used, honestly-- it's mostly here so I don't need to write it down somewhere else 😛 .

[elopio]

Agree. I use it a lot, so I appreciate when I can run the tests just using STAGING instead of the full urls.
wishlist bug?

[kyrofa]

Done.

[ricardokirkner]

When uploading via the web UI developers get the option not to automatically publish the update, but I think this doesn't apply to uploads via the API (which snapcraft uses), which means updates uploaded via snapcraft will be automatically published as well.

[kyrofa]

Ah, and that's why you needed to read it! Thanks, fixing now.

[ricardokirkner]

LGTM overall.

[elopio]

I would just use the word snaps, without the .

[elopio]

That involves what stuff?

[elopio]

s/make sure you have/set, and remove the "defined" at the end.

[elopio]

@ricardokirkner can we change OTP for something more user friendly like One-time password?
Also can we show it only when 2fa is enabled?

[ricardokirkner]

Printing a different string is certainly possible. Only requiring it for 2fa enabled accounts would require some non-trivial changes, essentially:

1. attempt the login without asking (nor sending) the OTP
2. if the login attempt fails, analyze the failure message and if the error is because an OTP is required, ask the user for it and retry step 1.

[kyrofa]

We at least need a way to say "press enter if you don't have 2fa enabled" or something. Because I expect a lot of users would stop right there.

[elopio]

@ricardokirkner could we not print this line?

[kyrofa]

I'm working on prettying that up now as part of LP: #1538692.

[ricardokirkner]

Possibly, would need investigating how to turn that off as that's being printed by urllib directly (under the hood)

[sergiusens]

Right, we solve this when using requests by upping the logging level for urllib.

[elopio]

Do you have to build it first, or snapcraft will build it if not found?

[kyrofa]

It will build it if not found. Should I mention that?

[ricardokirkner]

Possibly... it's a nice shortcut. Not sure how useful it'll be unless you're certain it'll built properly

[elopio]

I would also hide this line.

[kyrofa]

Yeah, also LP: #1538692.

[elopio]

When you put a dot at the end of an URL, the most common mistake is to use the dot when copy-pasting it.

[kyrofa]

Ah, I'll add that to the LP: #1538692 checklist.

[elopio]

uploaded an update is hard to say. What about uploaded a new version of an ...

[elopio]

Nice! Thanks for the great work @ricardokirkner.
And @kyrofa of course for documenting it.

[elopio]

This is great. Most of my comments are about things that can be reported as bugs for the future.

[elopio]

oh, right. And I guess we need to discuss if we should use .snap or snap.

[kyrofa]

oh, right. And I guess we need to discuss if we should use .snap or snap.

Nahh, I already replaced them. No problem!

[sergiusens]

👍 this will also make @dholbach very happy! 😄