/snapcraft

Make package installation dynamic to reduce deps #282

Merged
merged 1 commit into from Feb 1, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Jan 29, 2016

debian/control has a huge amount of dependencies that could very well
be installed depending on the project. There are also dependencies
included that are not relevant anymore.

The work here:

  • cleans up debian/control
  • adds logic to install the correct vcs tool depending on the source
    in snapcraft.yaml
  • makes sure all the examples have complete dependencies
  • cleans up .travis.yml

LP: #1539146
snapcraft/common.py
+ 'i686': 'i386-linux-gnu',
+ 'ppc64le': 'powerpc64le-linux-gnu',
+ 'x86_64': 'x86_64-linux-gnu',
+}
@kyrofa

kyrofa Feb 1, 2016

Member

This information is very closely related to the _DEB_ARCH above. Would the codebase be less prone to an update in one spot and forgetting to update the other if you stored this information within the same container? For example, a nested dict of the structure:

{
   'armv7l': {
      'arch': 'armhf',
      'triplet': 'arm-linux-gnueabihf',
   }
   # ...
}

You get the idea. Less duplication, still clear?

@sergiusens

sergiusens Feb 1, 2016

Collaborator

yeah, let me do that

@kyrofa
Member

kyrofa commented Feb 1, 2016

Small comment about combining the data structures for the arch-specific stuff, but looks good to me 👍 .
@sergiusens
Make package installation dynamic to reduce deps 
debian/control has a huge amount of dependencies that could very well
be installed depending on the project. There are also dependencies
included that are not relevant anymore.

The work here:

- cleans up debian/control
- adds logic to install the correct vcs tool depending on the source
  in snapcraft.yaml
- makes sure all the examples have complete dependencies
- cleans up .travis.yml

LP: #1539146

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.07%) to 93.343%
Details
9eae180

sergiusens added a commit that referenced this pull request Feb 1, 2016

@sergiusens
Merge pull request #282 from sergiusens/bugfix/1539146/smaller_depend… 
…encies

Make package installation dynamic to reduce deps
2b8f6e2

@sergiusens sergiusens merged commit 2b8f6e2 into snapcore:master Feb 1, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 93.343%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1539146/smaller_dependencies branch Feb 1, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #282 from sergiusens/bugfix/1539146/smaller_depend… 
…encies

Make package installation dynamic to reduce deps
b4be400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment