/snapcraft

Close fd on invalid credentials for upload #285

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sergiusens @elopio @ricardokirkner @kyrofa
@sergiusens
Collaborator

sergiusens commented Jan 30, 2016

No description provided.

@sergiusens
Collaborator

sergiusens commented Jan 30, 2016

this depends on #284
@elopio
Member

elopio commented Jan 30, 2016

ok to me.

@elopio elopio referenced this pull request Jan 30, 2016

Merged

Upload: Clean up output. #283

@ricardokirkner
Contributor

ricardokirkner commented Feb 1, 2016

LGTM. Would it no be possible to add a test to ensure file is closed after error from wrong credentials?
@kyrofa
Member

kyrofa commented Feb 1, 2016

Looks fine, though check the title before merge.
@sergiusens
Close fd on invalid credentials for upload 
LP: #1539814

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 93.272%
Details
c81c2f0

@sergiusens sergiusens changed the title from Bugfix/1539814/close fd on invalid credentials to @sergiusens Close fd on invalid credentials for upload Feb 1, 2016

@sergiusens sergiusens changed the title from @sergiusens Close fd on invalid credentials for upload to Close fd on invalid credentials for upload Feb 1, 2016

@kyrofa
Member

kyrofa commented Feb 1, 2016

Note that this bug is fixed in PR #283, which also includes a bit of a refactor.

@kyrofa kyrofa closed this Feb 1, 2016

@sergiusens sergiusens deleted the sergiusens:bugfix/1539814/close_fd_on_invalid_credentials branch Mar 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment