Close fd on invalid credentials for upload #285

Closed
wants to merge 1 commit into
from
Jump to file or symbol
Failed to load files and symbols.
+2 −1
Split
@@ -92,7 +92,6 @@ def upload_files(binary_filename, config=None):
updown_url = os.environ.get('UBUNTU_STORE_UPLOAD_ROOT_URL',
UBUNTU_STORE_UPLOAD_ROOT_URL)
unscanned_upload_url = urljoin(updown_url, 'unscanned-upload/')
- files = {'binary': open(binary_filename, 'rb')}
result = {'success': False, 'errors': []}
@@ -101,6 +100,8 @@ def upload_files(binary_filename, config=None):
result['errors'] = ['No valid credentials found.']
return result
+ files = {'binary': open(binary_filename, 'rb')}
+
try:
response = session.post(
unscanned_upload_url,