/snapcraft

Make requests-toolbelt and progressbar a Depends. #288

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kyrofa @sergiusens @dholbach
@kyrofa
Member

kyrofa commented Feb 3, 2016

This PR fixes LP: #1541349, where if Snapcraft is installed via the .deb and a user tries to login/upload a package, they get modules not found.
debian/control
@@ -32,8 +32,10 @@ Depends: python3-apt,
python3-jsonschema,
python3-lxml,
python3-pkg-resources,
+ python3-progressbar
@sergiusens

sergiusens Feb 3, 2016

Collaborator

missing ,

debian/control
python3-requests,
python3-requests-oauthlib,
+ python3-requests-toolbelt
@sergiusens

sergiusens Feb 3, 2016

Collaborator

missing ,

@kyrofa
Make requests-toolbelt and progressbar a Depends. 
Currently they're only Build-Depends.

LP: #1541349

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.0%) to 93.19%
Details
33ccd8c
@sergiusens
Collaborator

sergiusens commented Feb 3, 2016

👍 but I want @dholbach to also ack 😉
@dholbach
Contributor

dholbach commented Feb 3, 2016

👍 - go go go! 😄

sergiusens added a commit that referenced this pull request Feb 3, 2016

@sergiusens
Merge pull request #288 from kyrofa/bugfix/1541349/requests_toolbelt 
Make requests-toolbelt and progressbar a Depends.
20e242e

@sergiusens sergiusens merged commit 20e242e into snapcore:master Feb 3, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0%) to 93.19%
Details

@kyrofa kyrofa deleted the kyrofa:bugfix/1541349/requests_toolbelt branch Feb 29, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@ahmetb
Move RDMA pkg installation after provisioning (#288) 
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
b799158

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #288 from kyrofa/bugfix/1541349/requests_toolbelt 
Make requests-toolbelt and progressbar a Depends.
53d6197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment