Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
remote-build: introduce --launchpad-snapcraft-channel option #2933
It may be useful to configure Launchpad to use a specific
Signed-off-by: Chris Patterson email@example.com
It may be useful to configure Launchpad to use a specific snapcraft channel. This commit changes the default from "edge" to "stable", and allows the user to configure it. Signed-off-by: Chris Patterson <firstname.lastname@example.org>
@@ Coverage Diff @@ ## master #2933 +/- ## ========================================== + Coverage 88.07% 88.07% +<.01% ========================================== Files 229 229 Lines 16564 16565 +1 Branches 2552 2552 ========================================== + Hits 14588 14590 +2 Misses 1435 1435 + Partials 541 540 -1
"channel that snapcraft was on" being "edge"? Or matching the user's host-installed channel, if available? I just was under the impression edge was required at some point in order to function, but I'm probably wrong.
Pointing it to edge just feels like the wrong thing to do if the feature is eventually to be considered stable. But I do like the effect of encouraging more use of edge :D
Regardless, I think it would be wise to share this change with the reviewers and allow them to provide feedback with this in mind before they've completed their review. Though I don't know who that is.