Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote-build: introduce --launchpad-snapcraft-channel option #2933

Closed
wants to merge 1 commit into from

Conversation

@cjp256
Copy link
Member

cjp256 commented Feb 12, 2020

It may be useful to configure Launchpad to use a specific
snapcraft channel. This commit changes the default from "edge"
to "stable", and allows the user to configure it.

Signed-off-by: Chris Patterson chris.patterson@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

It may be useful to configure Launchpad to use a specific
snapcraft channel.  This commit changes the default from "edge"
to "stable", and allows the user to configure it.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #2933 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2933      +/-   ##
==========================================
+ Coverage   88.07%   88.07%   +<.01%     
==========================================
  Files         229      229              
  Lines       16564    16565       +1     
  Branches     2552     2552              
==========================================
+ Hits        14588    14590       +2     
  Misses       1435     1435              
+ Partials      541      540       -1
Impacted Files Coverage Δ
snapcraft/internal/remote_build/_launchpad.py 85.13% <ø> (ø) ⬆️
snapcraft/cli/remote.py 64% <100%> (+0.36%) ⬆️
snapcraft/internal/elf.py 80.56% <0%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c425ae...b425808. Read the comment docs.

Copy link
Collaborator

sergiusens left a comment

We agreed that we would default to the channel that snapcraft was on for this.
We are currently under design review, so let's not change the CLI atm

@cjp256

This comment has been minimized.

Copy link
Member Author

cjp256 commented Feb 13, 2020

We agreed that we would default to the channel that snapcraft was on for this.

"channel that snapcraft was on" being "edge"? Or matching the user's host-installed channel, if available? I just was under the impression edge was required at some point in order to function, but I'm probably wrong.

Pointing it to edge just feels like the wrong thing to do if the feature is eventually to be considered stable. But I do like the effect of encouraging more use of edge :D

We are currently under design review, so let's not change the CLI atm

😞 Does it really matter? I think exposing this feature is quite useful. We can address the deltas later (it is after all still warning as experimental).

Regardless, I think it would be wise to share this change with the reviewers and allow them to provide feedback with this in mind before they've completed their review. Though I don't know who that is.

@sergiusens

This comment has been minimized.

Copy link
Collaborator

sergiusens commented Feb 13, 2020

Let's just change the default to stable, I somehow missed this.
And the toggle we can discuss in that review.

@sergiusens

This comment has been minimized.

Copy link
Collaborator

sergiusens commented Feb 13, 2020

If you really want this, use SNAPCRAFT_BUILD_ENVIRONMENT_CHANNEL_SNAPCRAFT with a nice warning when used and default to stable.
This should be mostly a developer option.

@cjp256

This comment has been minimized.

Copy link
Member Author

cjp256 commented Feb 19, 2020

I will open a new PR with SNAPCRAFT_BUILD_ENVIRONMENT_CHANNEL_SNAPCRAFT.

@cjp256 cjp256 closed this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.