Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fix for missing content slot's 'content' property #2934

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

@cjp256
Copy link
Member

cjp256 commented Feb 13, 2020

Content was not being initialized correctly from the
snapcraft.yaml. Ensure it is used to create ContentSlot.

Update existing tests to ensure coverage of explicit content.

Signed-off-by: Chris Patterson chris.patterson@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Content was not being initialized correctly from the
snapcraft.yaml.  Ensure it is used to create ContentSlot.

Update existing tests to ensure coverage of explicit content.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 13, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@051f24e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2934   +/-   ##
=========================================
  Coverage          ?   88.14%           
=========================================
  Files             ?      229           
  Lines             ?    16574           
  Branches          ?     2554           
=========================================
  Hits              ?    14609           
  Misses            ?     1426           
  Partials          ?      539
Impacted Files Coverage Δ
snapcraft/internal/meta/slots.py 88.32% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051f24e...c84f74d. Read the comment docs.

@sergiusens sergiusens merged commit 4644651 into master Feb 13, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sergiusens sergiusens deleted the fix-content branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.