/snapcraft

Support setting an output file when snapping #303

Merged
merged 1 commit into from Feb 5, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @elopio
@sergiusens
Collaborator

sergiusens commented Feb 5, 2016

This adds support for -o or --output to have a deterministic
output file for a snap.

LP: #1542479

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@sergiusens
Collaborator

sergiusens commented Feb 5, 2016

This is a requirement to support cleanbuild so we will have to release after this
@elopio
Member

elopio commented Feb 5, 2016

lgtm. The unit test seems to be testing a lot of things not related to this branch, but it's ok to me, better safe than sorry.
@sergiusens
Support setting an output file when snapping 
This adds support for -o or --output to have a deterministic
output file for a snap.

LP: #1542479

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 93.208%
Details
18f55e5
@elopio
Member

elopio commented Feb 5, 2016

👍

sergiusens added a commit that referenced this pull request Feb 5, 2016

@sergiusens
Merge pull request #303 from sergiusens/feature/1542479/snapout 
Support setting an output file when snapping
34a80aa

@sergiusens sergiusens merged commit 34a80aa into snapcore:master Feb 5, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 93.208%
Details

@sergiusens sergiusens deleted the sergiusens:feature/1542479/snapout branch Feb 5, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@hglkrijger
Explicitly specify enable timeout as 5m (#303) 
* Explicitly specify enable timeout as 5m

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>

* fix unit tests
bda4e61

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #303 from sergiusens/feature/1542479/snapout 
Support setting an output file when snapping
7e28d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment