/snapcraft

Pre release unit test fix for 2.2 #312

Merged
merged 1 commit into from Feb 10, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @elopio
@sergiusens
Collaborator

sergiusens commented Feb 10, 2016

This considers builder environment variables that could potentially affect
unit tests.

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@sergiusens
Pre release unit test fix for 2.2 
This considers builder environment variables that could potentially affect
unit tests.

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
95bd7ff
@sergiusens
Collaborator

sergiusens commented Feb 10, 2016

Tested before (with failure) and after the fix with:
no_proxy='127.0.0.1' python3 -m unittest -v -b snapcraft.tests.test_plugin_maven.MavenPluginTestCase.test_build_with_snapcraft_proxy
@elopio
Member

elopio commented Feb 10, 2016

Confirmed here that the test fails without this change, and passes with it.
👍

elopio added a commit that referenced this pull request Feb 10, 2016

@elopio
Merge pull request #312 from sergiusens/hotfix/builder_env_vars 
Pre release unit test fix for 2.2
a44037e

@elopio elopio merged commit a44037e into snapcore:master Feb 10, 2016

@sergiusens sergiusens deleted the sergiusens:hotfix/builder_env_vars branch Feb 10, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@brendandixon @hglkrijger
Increment RC and ensure running agent is not deleted (#312) 
Signed-off-by: Brendan Dixon <brendand@microsoft.com>
2e004ae

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@elopio
Merge pull request #312 from sergiusens/hotfix/builder_env_vars 
Pre release unit test fix for 2.2
7c58820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment