Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Adding python-minimal to plugins that need it #316
Conversation
|
lgtm. The tests failed because of a hash mismatch. Retriggered... |
kyrofa
reviewed
Feb 11, 2016
| @@ -67,6 +67,7 @@ def __init__(self, name, options): | ||
| super().__init__(name, options) | ||
| self.stage_packages.extend([ | ||
| 'python-dev', | ||
| + 'python-minimal', |
kyrofa
Feb 11, 2016
Member
I'm afraid the fix for this one isn't so easy (fix doesn't work for me on xenial Classic Dimension). Perhaps the env() is used before pluginhandler.pull()?
sergiusens
Feb 11, 2016
Collaborator
It indeed might be, I pushed it here to see what happened on travis; I'm not sure how to fix this one since run is called from the class which generates an env by calling env.
|
Yeah that looks better. |
|
@kyrofa did it work for you? Or is it just looks |
|
@sergiusens testing it out now, but yeah, based on how it looks it seems to solve the issue I had. |
kyrofa
reviewed
Feb 11, 2016
| @@ -137,23 +145,11 @@ def build(self): | ||
| os.makedirs(self.dist_packages_dir, exist_ok=True) |
kyrofa
Feb 11, 2016
Member
You're still calling this, but you removed it. The examples tests will fail shortly
sergiusens
Feb 11, 2016
Collaborator
Weird that it would need to be created; no I see our unit test coverage sucks for these python plugins
|
@sergiusens alright, tested and verified: |
elopio
reviewed
Feb 11, 2016
| @@ -133,6 +134,17 @@ def get_schemadir(): | ||
| return _schemadir | ||
| +def get_python2_path(root): | ||
| + """Returns a valid PYTHONPATH or raises an exception.""" |
elopio
reviewed
Feb 11, 2016
| + try: | ||
| + env.append('PYTHONPATH={0}'.format(common.get_python2_path(root))) | ||
| + except EnvironmentError as e: | ||
| + logger.debug(e) |
elopio
Feb 11, 2016
Member
So no python is not a fatal error? Sounds weird.
But if that's the was, I think it should be warn, not debug.
kyrofa
Feb 11, 2016
Member
It's because this WILL happen when run is called, until the stage-packages have been installed.
sergiusens
Feb 11, 2016
Collaborator
@elopio I debated the case of using warn; but as @kyrofa mentions, it will happen a couple of times before it doesn't
elopio
reviewed
Feb 11, 2016
| + try: | ||
| + return glob.glob(os.path.join(root, 'usr', 'include', 'python2*'))[0] | ||
| + except IndexError: | ||
| + raise EnvironmentError('python development headers not installed') |
sergiusens
Feb 11, 2016
Collaborator
This is a programmatic error though as python-dev should be a required package for the python plugin (as it is now).
|
Some minor comments. |
added a commit
that referenced
this pull request
Feb 11, 2016
sergiusens
merged commit 61cc7a6
into
snapcore:master
Feb 11, 2016
sergiusens
deleted the
sergiusens:bugfix/1541451/python-minimal
branch
Feb 11, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
sergiusens commentedFeb 11, 2016
python-minimal is needed by the python2 and the catkin plugin.
LP: #1541451
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com