/snapcraft

More attributes for the squashfs'ed snap #334

Merged
merged 1 commit into from Feb 23, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @elopio @jdstrand
@sergiusens
Collaborator

sergiusens commented Feb 23, 2016

To make security better and easier to recreate snaps
we need to add -all-root, we also add -no-xattrs since
it is also an improvement that helps in preventing
people trying to circumvent the system.

LP: #1546821

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@sergiusens
More attributes for the squashfs'ed snap 
To make security better and easier to recreate snaps
we need to add -all-root, we also add -no-xattrs since
it is also an improvement that helps in preventing
people trying to circumvent the system.

LP: #1546821

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

3 successful checks
@snappy-m-o
Examples tests — Success 13 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.0009%) to 94.643%
Details
7df2fe5
@elopio
Member

elopio commented Feb 23, 2016

👍, pending a sanity check from Jamie.
@sergiusens
Collaborator

sergiusens commented Feb 23, 2016

@elopio so jamie already commented before you 😉
@sergiusens
Collaborator

sergiusens commented Feb 23, 2016

I swear I saw jamie ack and I based this out from a diff he was working on.

sergiusens added a commit that referenced this pull request Feb 23, 2016

@sergiusens
Merge pull request #334 from sergiusens/bugfix/1546821/squash-correctly 
More attributes for the squashfs'ed snap
e93fcc0

@sergiusens sergiusens merged commit e93fcc0 into snapcore:master Feb 23, 2016
3 checks passed

3 checks passed

Examples tests Success 13 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0009%) to 94.643%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1546821/squash-correctly branch Feb 23, 2016

@jdstrand

jdstrand commented Feb 23, 2016

I did ACK this-- not sure where it went...
@sergiusens
Collaborator

sergiusens commented Feb 24, 2016

Thanks for confirming I'm not crazy! :-)
@elopio
Member

elopio commented Feb 24, 2016

due to the lack of evidence, I can't be sure about who is not crazy here.

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #334 from sergiusens/bugfix/1546821/squash-correctly 
More attributes for the squashfs'ed snap
bb566e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment