/snapcraft

Autotools plugin: Support installing via prefix. #351

Merged
merged 1 commit into from Mar 1, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kyrofa @elopio @sergiusens
@kyrofa
Member

kyrofa commented Feb 29, 2016

Currently autotools installs via DESTDIR, but not all autotools projects work that way. This PR fixes LP: #1544629 by adding a config option that enables the prefix to be used instead.
@kyrofa
Autotools plugin: Support installing via prefix. 
Currently autotools installs via DESTDIR, but not all autotools
projects work that way. This commit adds a config option enabling
the prefix to be used instead.

LP: #1544629

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

All checks have passed

3 successful checks
@snappy-m-o
Examples tests — Success 13 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.3%) to 94.745%
Details
72dbc32
@elopio
Member

elopio commented Feb 29, 2016

👍 from me. I don't like install-via, but I can't think of anything better.
I think that install-to: prefix or install-to: destdir reads a little better, but I'm ok with anything Kyle decides.
@sergiusens
Collaborator

sergiusens commented Feb 29, 2016

The problem with install-to is that both put the files in the same location, what changes is the mechanism
@sergiusens
Collaborator

sergiusens commented Feb 29, 2016

👍

@kyrofa kyrofa referenced this pull request Feb 29, 2016

Merged

Backport to 1.x: Autotools plugin: Support installing via prefix. #352

sergiusens added a commit that referenced this pull request Mar 1, 2016

@sergiusens
Merge pull request #351 from kyrofa/feature/1544629/autotools_support… 
…_install_via_prefix

Autotools plugin: Support installing via prefix.
aae4e85

@sergiusens sergiusens merged commit aae4e85 into snapcore:master Mar 1, 2016
3 checks passed

3 checks passed

Examples tests Success 13 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 94.745%
Details

@kyrofa kyrofa deleted the kyrofa:feature/1544629/autotools_support_install_via_prefix branch Mar 1, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #351 from kyrofa/feature/1544629/autotools_support… 
…_install_via_prefix

Autotools plugin: Support installing via prefix.
1af7a7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment