/snapcraft

Skip the BasePlugin from plugin search #353

Merged
merged 1 commit into from Mar 1, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @kyrofa @elopio
@sergiusens
Collaborator

sergiusens commented Feb 29, 2016

This is to support the case of a plugin importing baseplugin
as a symbol instead of the module.

LP: #1547681

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@kyrofa
Member

kyrofa commented Feb 29, 2016

Yeah looks fine to me 👍
@elopio
Member

elopio commented Feb 29, 2016

lgtm.
@sergiusens
Skip the BasePlugin from plugin search 
This is to support the case of a plugin importing baseplugin
as a symbol instead of the module.

LP: #1547681

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 13 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.03%) to 94.75%
Details
fe479a4

sergiusens added a commit that referenced this pull request Mar 1, 2016

@sergiusens
Merge pull request #353 from sergiusens/bug/1547681/all-your-base 
Skip the BasePlugin from plugin search
d2d428b

@sergiusens sergiusens merged commit d2d428b into snapcore:master Mar 1, 2016
4 checks passed

4 checks passed

Examples tests Success 13 tests run, 0 skipped, 0 failed.
Details
autopkgtest Success No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 94.75%
Details

@sergiusens sergiusens deleted the sergiusens:bug/1547681/all-your-base branch Mar 1, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@brendandixon
Merge pull request #357 from brendandixon/gh353 
Ensure all SSH keys are created before restarting SSH daemon (#353)
c332dd7

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #353 from sergiusens/bug/1547681/all-your-base 
Skip the BasePlugin from plugin search
13adf2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment