/snapcraft

Expose the invalid build-package on error #355

Merged
merged 1 commit into from Mar 1, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Mar 1, 2016

The error that results from using an invalid build-package
is not very specific. This exposes the KeyError raised by apt.

LP: #1547672

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@sergiusens
Expose the invalid build-package on error 
The error that results from using an invalid build-package
is not very specific. This exposes the KeyError raised by apt.

LP: #1547672

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 13 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.003%) to 94.752%
Details
8bc9e05
@kyrofa
Member

kyrofa commented Mar 1, 2016

Yeah, much better! 👍
integration_tests/test_snap.py
- 'Could not find all the "build-packages" required in '
- 'snapcraft.yaml\n')
+ "Could not find a required package in 'build-packages': "
+ '"The cache has\nno package named \'inexistent-package\'"\n')
@kyrofa

kyrofa Mar 1, 2016

Member

The newline in here is throwing me. Why is it here and not in the other test below?

@sergiusens

sergiusens Mar 1, 2016

Collaborator

dedent usage in snapcraft.main

sergiusens added a commit that referenced this pull request Mar 1, 2016

@sergiusens
Merge pull request #355 from sergiusens/bugfix/1547672/mention-the-pa… 
…ckage

Expose the invalid build-package on error
f4b75f9

@sergiusens sergiusens merged commit f4b75f9 into snapcore:master Mar 1, 2016
4 checks passed

4 checks passed

Examples tests Success 13 tests run, 0 skipped, 0 failed.
Details
autopkgtest Success No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 94.752%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1547672/mention-the-package branch Mar 1, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #355 from sergiusens/bugfix/1547672/mention-the-pa… 
…ckage

Expose the invalid build-package on error
e64a268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment