/snapcraft

Set a sane umask to create a proper snap #358

Closed
wants to merge 2 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Mar 1, 2016

This seems to solve the bug, I'm not sure how to add tests for this though (and not even sure it is worth it).
@sergiusens
Set a sane umask to create a proper snap 
LP: #1515394

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

Some checks were not successful

1 failing and 3 successful checks
@snappy-m-o
Examples tests — 13 tests run, 0 skipped, 1 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 94.824%
Details
35e8b91
@kyrofa
Member

kyrofa commented Mar 1, 2016

This looks sensible 👍 . Agreed that testing would be wonky.
@sergiusens
Merge branch 'master' into bugfix/1515394/sane-umask

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 13 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.002%) to 94.824%
Details
1a0b615

@sergiusens sergiusens closed this Mar 1, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@hglkrijger
Merge pull request #358 from hglkrijger/master 
fix dd command
e24bfe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment