/snapcraft

Set a sane umask to create a proper snap #360

Closed
wants to merge 1 commit into
from
+37 −0

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @kyrofa @jdstrand
@sergiusens
Collaborator

sergiusens commented Mar 2, 2016

LP: #1515394

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@kyrofa
Member

kyrofa commented Mar 3, 2016

Yeah I like it 👍
@sergiusens
Collaborator

sergiusens commented Mar 3, 2016

This will be super naggy though
@kyrofa
Member

kyrofa commented Mar 3, 2016

How so? Won't most people have 0022 or 0002?
@sergiusens
Collaborator

sergiusens commented Mar 3, 2016

@kyrofa Naggy in the sense it will be spat out after every command that's run.
@kyrofa
Member

kyrofa commented Mar 3, 2016

@sergiusens ah. I don't see a way around that, though, unless you touch, say, parts/.umask_warned or something. But honestly, enough is printed with every command I'm more worried about the potential for this warning to be lost completely.
@sergiusens
Set a sane umask to create a proper snap 
LP: #1515394

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

Some checks were not successful

1 errored, 1 failing, and 1 successful checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
@snappy-m-o
Examples tests — 13 tests run, 0 skipped, 2 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
36d6010
@jdstrand

jdstrand commented Mar 3, 2016

LGTM, thanks!

@sergiusens sergiusens closed this Apr 26, 2016

@sergiusens sergiusens deleted the sergiusens:bugfix/1515394/sane-umask branch Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment