/snapcraft

Remove the useles decode done in tests. #362

Merged
merged 1 commit into from Mar 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @kyrofa
@sergiusens
Collaborator

sergiusens commented Mar 2, 2016

The examples tests shell out and capture output but this output
is not used so we should not decode it.

LP: #1552403

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@kyrofa
Member

kyrofa commented Mar 2, 2016

Yup 👍
@sergiusens
Remove the useles decode done in tests. 
The examples tests shell out and capture output but this output
is not used so we should not decode it.

LP: #1552403

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

Some checks were not successful

1 errored, 1 failing, and 1 successful checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
@snappy-m-o
Examples tests — 13 tests run, 0 skipped, 1 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
c6e0d50

sergiusens added a commit that referenced this pull request Mar 3, 2016

@sergiusens
Merge pull request #362 from sergiusens/bugfix/1552403/no-useless-decode 
Remove the useles decode done in tests.
6d17a60

@sergiusens sergiusens merged commit 6d17a60 into snapcore:master Mar 3, 2016
1 of 3 checks passed

1 of 3 checks passed

Examples tests 13 tests run, 0 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
autopkgtest Success No test results found.
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1552403/no-useless-decode branch Mar 3, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@hglkrijger
update version to 2.1.6 (#362) 
* update version to 2.1.6

* fix unit test
ae94587

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #362 from sergiusens/bugfix/1552403/no-useless-decode 
Remove the useles decode done in tests.
293860a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment