Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: Give priority to local environment #3772

Conversation

sergio-costas
Copy link
Contributor

@sergio-costas sergio-costas commented Jun 1, 2022

When creating the environment for gnome shell, the order in which the variables from the SDK should be added was reversed: the SDK ones should be at the end, and the new elements should be at the beginning. This allows to priorityze the local changes over the generic elements in the SDK.

This MR re-applies #3761 after being superseded by #3766

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #3772 (3ba5b1a) into feature/core22-gnome-extension (305b7cc) will not change coverage.
The diff coverage is n/a.

❗ Current head 3ba5b1a differs from pull request most recent head 85e91e3. Consider uploading reports for the commit 85e91e3 to get more accurate results

@@                       Coverage Diff                       @@
##           feature/core22-gnome-extension    #3772   +/-   ##
===============================================================
  Coverage                           86.98%   86.98%           
===============================================================
  Files                                  63       63           
  Lines                                3566     3566           
===============================================================
  Hits                                 3102     3102           
  Misses                                464      464           
Impacted Files Coverage Δ
snapcraft/extensions/gnome.py 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sergio-costas sergio-costas force-pushed the give_priority_to_local_environment branch from fb19177 to b3cacd0 Compare June 1, 2022 13:09
@sergiusens sergiusens force-pushed the core22-gnome-extension branch 8 times, most recently from 0c24196 to e968076 Compare June 7, 2022 01:48
@sergio-costas sergio-costas force-pushed the give_priority_to_local_environment branch 2 times, most recently from b476732 to d8c6cb9 Compare June 7, 2022 08:30
@sergiusens sergiusens force-pushed the core22-gnome-extension branch 4 times, most recently from c70a95d to 709b79a Compare June 8, 2022 00:13
@sergio-costas sergio-costas force-pushed the give_priority_to_local_environment branch from d8c6cb9 to 17382d2 Compare June 8, 2022 07:42
sergiusens and others added 4 commits June 20, 2022 15:03
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Simplify the management of environment variables, allowing to just pass
the name of one variable and one or more paths, and they will return a
piece of shell code that prepends or appends the paths to the variable,
taking into account the case when the variable is empty, to avoid adding
a trailing or leading colon.
Allow for overriding the sdk and default provider for the content of the
 GNOME extension.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergio-costas sergio-costas force-pushed the give_priority_to_local_environment branch 2 times, most recently from f5a6f15 to 3ba5b1a Compare June 23, 2022 14:24
When creating the environment for gnome shell, the order in
which the variables from the SDK should be added was reversed:
the SDK ones should be at the end, and the new elements should
be at the beginning. This allows to priorityze the local
changes over the generic elements in the SDK.

This MR re-applies canonical#3761 after being superseded by canonical#3766
@sergio-costas sergio-costas force-pushed the give_priority_to_local_environment branch from 3ba5b1a to 85e91e3 Compare June 23, 2022 15:04
@sergiusens sergiusens force-pushed the feature/core22-gnome-extension branch from 305b7cc to 0a1ddd9 Compare June 28, 2022 15:41
@sergiusens sergiusens force-pushed the feature/core22-gnome-extension branch 6 times, most recently from 86aa854 to 6855bd3 Compare June 29, 2022 18:18
@sergiusens sergiusens deleted the branch canonical:feature/core22-gnome-extension July 1, 2022 00:39
@sergiusens sergiusens closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants