New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensions: Give priority to local environment #3772
Closed
sergio-costas
wants to merge
5
commits into
canonical:feature/core22-gnome-extension
from
sergio-costas:give_priority_to_local_environment
Closed
extensions: Give priority to local environment #3772
sergio-costas
wants to merge
5
commits into
canonical:feature/core22-gnome-extension
from
sergio-costas:give_priority_to_local_environment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/core22-gnome-extension #3772 +/- ##
===============================================================
Coverage 86.98% 86.98%
===============================================================
Files 63 63
Lines 3566 3566
===============================================================
Hits 3102 3102
Misses 464 464
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
sergio-costas
force-pushed
the
give_priority_to_local_environment
branch
from
June 1, 2022 13:09
fb19177
to
b3cacd0
Compare
sergiusens
force-pushed
the
core22-gnome-extension
branch
8 times, most recently
from
June 7, 2022 01:48
0c24196
to
e968076
Compare
sergio-costas
force-pushed
the
give_priority_to_local_environment
branch
2 times, most recently
from
June 7, 2022 08:30
b476732
to
d8c6cb9
Compare
sergiusens
force-pushed
the
core22-gnome-extension
branch
4 times, most recently
from
June 8, 2022 00:13
c70a95d
to
709b79a
Compare
sergio-costas
force-pushed
the
give_priority_to_local_environment
branch
from
June 8, 2022 07:42
d8c6cb9
to
17382d2
Compare
sergiusens
reviewed
Jun 9, 2022
sergio-costas
force-pushed
the
give_priority_to_local_environment
branch
from
June 9, 2022 16:05
17382d2
to
909102f
Compare
sergiusens
force-pushed
the
core22-gnome-extension
branch
from
June 9, 2022 17:38
709b79a
to
5ad5dbb
Compare
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Simplify the management of environment variables, allowing to just pass the name of one variable and one or more paths, and they will return a piece of shell code that prepends or appends the paths to the variable, taking into account the case when the variable is empty, to avoid adding a trailing or leading colon.
Allow for overriding the sdk and default provider for the content of the GNOME extension. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
core22-gnome-extension
branch
from
June 20, 2022 18:04
5ad5dbb
to
305b7cc
Compare
sergio-costas
force-pushed
the
give_priority_to_local_environment
branch
2 times, most recently
from
June 23, 2022 14:24
f5a6f15
to
3ba5b1a
Compare
When creating the environment for gnome shell, the order in which the variables from the SDK should be added was reversed: the SDK ones should be at the end, and the new elements should be at the beginning. This allows to priorityze the local changes over the generic elements in the SDK. This MR re-applies canonical#3761 after being superseded by canonical#3766
sergio-costas
force-pushed
the
give_priority_to_local_environment
branch
from
June 23, 2022 15:04
3ba5b1a
to
85e91e3
Compare
sergiusens
force-pushed
the
feature/core22-gnome-extension
branch
from
June 28, 2022 15:41
305b7cc
to
0a1ddd9
Compare
sergiusens
force-pushed
the
feature/core22-gnome-extension
branch
6 times, most recently
from
June 29, 2022 18:18
86aa854
to
6855bd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the environment for gnome shell, the order in which the variables from the SDK should be added was reversed: the SDK ones should be at the end, and the new elements should be at the beginning. This allows to priorityze the local changes over the generic elements in the SDK.
This MR re-applies #3761 after being superseded by #3766
make lint
?pytest tests/unit
?