Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: refactor #3781

Merged
merged 1 commit into from Jun 8, 2022
Merged

extensions: refactor #3781

merged 1 commit into from Jun 8, 2022

Conversation

sergiusens
Copy link
Collaborator

Avoid future cyclic import issues.

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Part of #3760
CRAFT-1114

- avoid future cyclic import issues
- remove duplicate conftest.py

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3781 (986a989) into main (a8a3f2e) will decrease coverage by 0.08%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #3781      +/-   ##
==========================================
- Coverage   87.09%   87.00%   -0.09%     
==========================================
  Files          59       59              
  Lines        3393     3394       +1     
==========================================
- Hits         2955     2953       -2     
- Misses        438      441       +3     
Impacted Files Coverage Δ
snapcraft/extensions/__init__.py 100.00% <ø> (ø)
snapcraft/extensions/extension.py 100.00% <ø> (ø)
snapcraft/extensions/_utils.py 98.33% <66.66%> (-1.67%) ⬇️
snapcraft/extensions/registry.py 88.88% <71.42%> (-11.12%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sergiusens sergiusens merged commit 52155ff into main Jun 8, 2022
@sergiusens sergiusens deleted the extensions_refactor branch June 8, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants