/snapcraft

Support downloading snaps #379

Merged
merged 1 commit into from Mar 18, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sergiusens @coveralls @kyrofa @ogra1
@sergiusens
Collaborator

sergiusens commented Mar 18, 2016

This is implemented to support kernel building

LP: #1558970

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@sergiusens
Support downloading snaps 
This is implemented to support kernel building

LP: #1558970

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 14 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.07%) to 95.356%
Details
b9e6cc3
@coveralls

coveralls commented Mar 18, 2016

Coverage Status

Coverage increased (+0.07%) to 95.356% when pulling b9e6cc3 on sergiusens:feature/1558970/download-snap into 5b3dd6a on ubuntu-core:master.
@kyrofa
Member

kyrofa commented Mar 18, 2016

👍 looks good to me!
@ogra1

ogra1 commented Mar 18, 2016

the initrd.img files comes originally from a deb in the archive. is it really necessary to pull the whole rootfs snap just to extract a 2MB file from it instead of just pulling the .deb package from the archive ?
@sergiusens
Collaborator

sergiusens commented Mar 18, 2016

Just for the record as I mentioned this to @ogra1 on irc; we plan to remove this as soon as the generic initrd work is complete on the snappy side and it learns to pick it up

sergiusens added a commit that referenced this pull request Mar 18, 2016

@sergiusens
Merge pull request #379 from sergiusens/feature/1558970/download-snap 
Support downloading snaps

All checks have passed

2 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — First build on master at 95.371%
Details
0c31143

@sergiusens sergiusens merged commit 0c31143 into snapcore:master Mar 18, 2016
4 checks passed

4 checks passed

Examples tests Success 14 tests run, 0 skipped, 0 failed.
Details
autopkgtest Success No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 95.356%
Details

@sergiusens sergiusens deleted the sergiusens:feature/1558970/download-snap branch Mar 18, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@dm0- @hglkrijger
Clean up the CoreOS osutil class (#379) 
* osutil/coreos: clean most pylint problems

* osutil/coreos: fix misspelled service name

* osutil/coreos: use systemctl to get the real PID
902dead

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #379 from sergiusens/feature/1558970/download-snap 
Support downloading snaps
98e74d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment