/snapcraft

Snaps of type os should not squash with -all-root #391

Merged
merged 1 commit into from Mar 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @coveralls @kyrofa
@sergiusens
Collaborator

sergiusens commented Mar 22, 2016

When creating os snaps we want to preserve user permissions.

LP: #1557513

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@coveralls

coveralls commented Mar 22, 2016

Coverage Status

Coverage increased (+0.02%) to 95.458% when pulling 1c314cb on sergiusens:bugfix/1557513/os-snap-should-no-all-root into 94fe595 on ubuntu-core:master.
@kyrofa
Member

kyrofa commented Mar 22, 2016

Looks good! 👍
@sergiusens
Snaps of type os should not squash with -all-root 
When creating os snaps we want to preserve user permissions.

LP: #1557513

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 14 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 95.458%
Details
13a0d1c
@coveralls

coveralls commented Mar 22, 2016

Coverage Status

Coverage increased (+0.02%) to 95.458% when pulling 13a0d1c on sergiusens:bugfix/1557513/os-snap-should-no-all-root into c56bea0 on ubuntu-core:master.

sergiusens added a commit that referenced this pull request Mar 22, 2016

@sergiusens
Merge pull request #391 from sergiusens/bugfix/1557513/os-snap-should… 
…-no-all-root

Snaps of type os should not squash with -all-root

All checks have passed

2 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — First build on master at 95.458%
Details
8887fe6

@sergiusens sergiusens merged commit 8887fe6 into snapcore:master Mar 22, 2016
4 checks passed

4 checks passed

Examples tests Success 14 tests run, 0 skipped, 0 failed.
Details
autopkgtest Success No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 95.458%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1557513/os-snap-should-no-all-root branch Mar 22, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #391 from sergiusens/bugfix/1557513/os-snap-should… 
…-no-all-root

Snaps of type os should not squash with -all-root
7a528a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment