/snapcraft

Include and library paths must exist #397

Merged
merged 1 commit into from Mar 24, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sergiusens @coveralls @kyrofa @elopio
@sergiusens
Collaborator

sergiusens commented Mar 23, 2016

CXXFLAGS was also missing here.

LP: #1558965

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@coveralls

coveralls commented Mar 23, 2016

Coverage Status

Coverage increased (+0.01%) to 95.479% when pulling 88731e7 on sergiusens:bugfix/1558965/path-must-exist into 889fe87 on ubuntu-core:master.

@sergiusens sergiusens referenced this pull request Mar 23, 2016

Closed

Also set CXXFLAGS #374

snapcraft/tests/test_yaml.py
- expected))
+ self.assertTrue(
+ expected in paths,
+ 'Expected LD_LIBRARY_PATH in {!r} to include {!r}'.format(
@kyrofa

kyrofa Mar 23, 2016

Member

Perhaps Expected LD_LIBRARY_PATH ({!r}) to include {!r} would make more sense here?

snapcraft/yaml.py
+ return ''
+ else:
+ return '{envvar}="{library_paths}{sep}${envvar}"'.format(
+ envvar=envvar, sep=sep, library_paths=sep.join(library_paths))
@kyrofa

kyrofa Mar 23, 2016

Member

Hey, that's pretty slick.

@kyrofa
Member

kyrofa commented Mar 23, 2016

Looks good to me 👍
@sergiusens
Collaborator

sergiusens commented Mar 23, 2016

retest this please
@coveralls

coveralls commented Mar 23, 2016

Coverage Status

Coverage increased (+0.02%) to 95.489% when pulling f59a7f4 on sergiusens:bugfix/1558965/path-must-exist into 889fe87 on ubuntu-core:master.
@coveralls

coveralls commented Mar 23, 2016

Coverage Status

Coverage increased (+0.02%) to 95.489% when pulling 2f7d99e on sergiusens:bugfix/1558965/path-must-exist into 889fe87 on ubuntu-core:master.
@elopio
Member

elopio commented Mar 23, 2016

retest this please
@coveralls

coveralls commented Mar 23, 2016

Coverage Status

Coverage increased (+0.02%) to 95.489% when pulling 7c0ffb8 on sergiusens:bugfix/1558965/path-must-exist into 889fe87 on ubuntu-core:master.
@sergiusens
Include and library paths must exist 
CXXFLAGS was also missing here.

LP: #1558965

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 14 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.008%) to 95.526%
Details
b7e1986
@coveralls

coveralls commented Mar 23, 2016

Coverage Status

Coverage increased (+0.008%) to 95.526% when pulling b7e1986 on sergiusens:bugfix/1558965/path-must-exist into 5a099d2 on ubuntu-core:master.

@sergiusens sergiusens merged commit 2037d9c into snapcore:master Mar 24, 2016
4 checks passed

4 checks passed

Examples tests Success 14 tests run, 0 skipped, 0 failed.
Details
autopkgtest Success No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.008%) to 95.526%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1558965/path-must-exist branch Mar 24, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@brendandixon
Merge pull request #397 from hglkrijger/gh391 
update setup.py to start service on register-service
d039290

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #397 from sergiusens/bugfix/1558965/path-must-exist 
Include and library paths must exist
42ce5d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment