/snapcraft

Added valid STEPs info to clean command #403

Closed
wants to merge 3 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dplanella @snappy-m-o @coveralls @kyrofa
@dplanella

dplanella commented Mar 24, 2016

Added information of the valid STEP values to pass to snapcraft clean -s. The extra info will be shown on the output of snapcraft clean --help.
@dplanella
Added valid STEPs info to clean command 
Added information of the valid STEP values to pass to `snapcraft clean -s`. The extra info will be shown on the output of `snapcraft clean --help`.

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 14 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.867%
Details
70bf9d9
@snappy-m-o

snappy-m-o commented Mar 24, 2016

Can one of the admins verify this patch?
@snappy-m-o

snappy-m-o commented Mar 24, 2016

Can one of the admins verify this patch?
@coveralls

coveralls commented Mar 24, 2016

Coverage Status

Coverage remained the same at 95.867% when pulling 70bf9d9 on dplanella:patch-1 into 3c2081a on ubuntu-core:master.
snapcraft/commands/clean.py
@@ -26,7 +26,8 @@
Options:
-h --help show this help message and exit.
-s STEP --step=STEP only clean the specified step and those that depend
- upon it.
+ upon it. STEP can be one of: pull, build, stage, strip,
+ snap. See 'snapcraft help plugins' to learn more.
@kyrofa

kyrofa Mar 24, 2016

Member

Ah, good addition, thank you! However, these steps are per-part, and snap isn't a per-part step, so it's just pull, build, stage, or strip.

dplanella added some commits Mar 25, 2016

@dplanella
Removed reference to 'snap' in the 'clean' help

All checks have passed

3 successful checks
@snappy-m-o
Examples tests — Success 14 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
01102cd
@dplanella
Merge branch 'master' into patch-1

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 14 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.871%
Details
30f724a
@dplanella

dplanella commented Mar 25, 2016

Thanks Kyle, updated as per the comment.
@coveralls

coveralls commented Mar 25, 2016

Coverage Status

Coverage remained the same at 95.871% when pulling 30f724a on dplanella:patch-1 into 56894e8 on ubuntu-core:master.
@kyrofa
Member

kyrofa commented Mar 28, 2016

@dplanella looks good. If you could please rebase onto master and squash into a single commit, we'll get this in 😃 .
@kyrofa
Member

kyrofa commented Apr 4, 2016

Fixed in #423.

@kyrofa kyrofa closed this Apr 4, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@brendandixon
Merge pull request #403 from hglkrijger/gh389 
ensure null bytes are not present in shlex input
0c25cc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment