/snapcraft

Explain the new way to provide snap icons. #409

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sergiusens @coveralls @elopio @kyrofa
@sergiusens
Collaborator

sergiusens commented Mar 29, 2016

LP: #1561327

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
@coveralls

coveralls commented Mar 29, 2016

Coverage Status

Coverage remained the same at 95.884% when pulling 463349b on sergiusens:bugfix/1561327/icon-in-setup into 1b15b6a on ubuntu-core:master.
docs/metadata.md
+
+To provide an icon for your snap, while for command line applications might
+not seem as important it is rather important for discoverability from
+management interfaces such as store fronts like webdm.
@kyrofa

kyrofa Mar 29, 2016

Member

This could flow a bit better. Perhaps something like "Providing an icon for your snap is important, even for command-line applications, if for nothing else than discoverability from management[...]"

@sergiusens

sergiusens Mar 29, 2016

Collaborator

Fixed

snapcraft/meta.py
@@ -105,7 +105,11 @@ def _setup_assets(meta_dir, config_data):
os.link(config_data['license'], license_path)
if 'icon' in config_data:
- logger.warning("DEPRECATED: 'icon' defined in snapcraft.yaml")
+ # TODO: use developer.ubuntu.com once it has updated documentation.
@kyrofa

kyrofa Mar 29, 2016

Member

Is there an issue for this so we can track it?

@sergiusens

sergiusens Mar 29, 2016

Collaborator

Not that I know of.

@sergiusens
Explain the new way to provide snap icons. 
LP: #1561327

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 14 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.884%
Details
d460d9d
@elopio
Member

elopio commented Mar 29, 2016

👍
@coveralls

coveralls commented Mar 29, 2016

Coverage Status

Coverage remained the same at 95.884% when pulling d460d9d on sergiusens:bugfix/1561327/icon-in-setup into 1b15b6a on ubuntu-core:master.
@kyrofa
Member

kyrofa commented Mar 29, 2016

👍

@sergiusens sergiusens merged commit 4073f89 into snapcore:master Mar 29, 2016
4 checks passed

4 checks passed

Examples tests Success 14 tests run, 0 skipped, 0 failed.
Details
autopkgtest Success No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.884%
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1561327/icon-in-setup branch Aug 30, 2016

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
Merge pull request #409 from sergiusens/bugfix/1561327/icon-in-setup 
Explain the new way to provide snap icons.
db649c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment