/snapcraft

Add a test for the mosquitto example. #418

Merged
merged 2 commits into from Apr 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@elopio @sergiusens @kyrofa
@elopio
Member

elopio commented Apr 1, 2016

LP: 1564181
@elopio
Member

elopio commented Apr 1, 2016

retest this please
@elopio
Member

elopio commented Apr 4, 2016

retest this please
@elopio
Member

elopio commented Apr 4, 2016

retest this please
@elopio
Member

elopio commented Apr 4, 2016

restest this please
@sergiusens
Collaborator

sergiusens commented Apr 4, 2016

@elopio it needs to be LP: #XXXXX iirc, no worries, I'll fix when merging
@sergiusens
Collaborator

sergiusens commented Apr 4, 2016

@elopio

======================================================================
ERROR: test_mosquitto.MosquittoTestCase.test_mosquitto
----------------------------------------------------------------------
output: {{{b"Preparing to pull mqtt-paho-py3 \n\rGet:1 http://security.ubuntu.com/ubuntu xenial-security InRelease [82.2 kB]\n\rGet:2 http://archive.ubuntu.com/ubuntu xenial InRelease [95.6 kB]\n\rGet:3 http://archive.ubuntu.com/ubuntu xenial-updates InRelease [82.2 kB]\n\rGet:4 http://security.ubuntu.com/ubuntu xenial-security/main amd64 Packages [28 B]\n\rGet:5 http://security.ubuntu.com/ubuntu xenial-security/restricted amd64 Packages [28 B]\n\rGet:6 http://security.ubuntu.com/ubuntu xenial-security/universe amd64 Packages [28 B]\n\rGet:7 http://security.ubuntu.com/ubuntu xenial-security/multiverse amd64 Packages [28 B]\n\rGet:8 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages [1436 kB]\n\rGet:9 http://archive.ubuntu.com/ubuntu xenial/restricted amd64 Packages [10.5 kB]\n\rGet:10 http://archive.ubuntu.com/ubuntu xenial/universe amd64 Packages [7243 kB]\n\rGet:11 http://archive.ubuntu.com/ubuntu xenial/multiverse amd64 Packages [146 kB]\n\rGet:12 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages [28 B]\n\rGet:13 http://archive.ubuntu.com/ubuntu xenial-updates/restricted amd64 Packages [28 B]\n\rGet:14 http://archive.ubuntu.com/ubuntu xenial-updates/universe amd64 Packages [28 B]\n\rGet:15 http://archive.ubuntu.com/ubuntu xenial-updates/multiverse amd64 Packages [28 B]\n\rFetched 9096 kB in 0s (0 B/s)\nSkipping blacklisted from manifest packages: ['adduser', 'apt', 'apt-utils', 'base-files', 'base-passwd', 'bash', 'bsdutils', 'coreutils', 'dash', 'debconf', 'debconf-i18n', 'debianutils', 'diffutils', 'dmsetup', 'dpkg', 'e2fslibs', 'e2fsprogs', 'file', 'findutils', 'gcc-4.9-base', 'gcc-5-base', 'gnupg', 'gpgv', 'grep', 'gzip', 'hostname', 'init', 'initscripts', 'insserv', 'libacl1', 'libapparmor1', 'libattr1', 'libaudit-common', 'libaudit1', 'libblkid1', 'libbz2-1.0', 'libc-bin', 'libc6', 'libcap2', 'libcap2-bin', 'libcomerr2', 'libcryptsetup4', 'libdb5.3', 'libdebconfclient0', 'libdevmapper1.02.1', 'libgcc1', 'libgcrypt20', 'libgpg-error0', 'libgpm2', 'libkmod2', 'liblocale-gettext-perl', 'liblzma5', 'libmagic1', 'libmount1', 'libncurses5', 'libncursesw5', 'libpam-modules', 'libpam-modules-bin', 'libpam-runtime', 'libpam0g', 'libpcre3', 'libreadline6', 'libselinux1', 'libsemanage-common', 'libsemanage1', 'libsepol1', 'libslang2', 'libsmartcols1', 'libss2', 'libstdc++6', 'libsystemd0', 'libtext-charwidth-perl', 'libtext-iconv-perl', 'libtext-wrapi18n-perl', 'libtinfo5', 'libudev1', 'libusb-0.1-4', 'libustr-1.0-1', 'libuuid1', 'locales', 'login', 'lsb-base', 'makedev', 'manpages', 'manpages-dev', 'mawk', 'mount', 'multiarch-support', 'ncurses-base', 'ncurses-bin', 'passwd', 'perl-base', 'procps', 'readline-common', 'sed', 'sensible-utils', 'systemd', 'systemd-sysv', 'sysv-rc', 'sysvinit-utils', 'tar', 'tzdata', 'ubuntu-keyring', 'udev', 'util-linux', 'zlib1g']\n\rGet:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 libssl1.0.0 amd64 1.0.2g-1ubuntu2 [1079 kB]\n\rGet:2 http://archive.ubuntu.com/ubuntu xenial/main amd64 libpython3.5-minimal amd64 3.5.1-10 [521 kB]\n\rGet:3 http://archive.ubuntu.com/ubuntu xenial/main amd64 libexpat1 amd64 2.1.0-7 [71.4 kB]\n\rGet:4 http://archive.ubuntu.com/ubuntu xenial/main amd64 python3.5-minimal amd64 3.5.1-10 [1588 kB]\n\rGet:5 http://archive.ubuntu.com/ubuntu xenial/main amd64 python3-minimal amd64 3.5.1-3 [23.3 kB]\n\rGet:6 http://archive.ubuntu.com/ubuntu xenial/main amd64 mime-support all 3.59ubuntu1 [31.0 kB]\n\rGet:7 http://archive.ubuntu.com/ubuntu xenial/main amd64 libffi6 amd64 3.2.1-4 [17.8 kB]\n\rGet:8 http://archive.ubuntu.com/ubuntu xenial/main amd64 libmpdec2 amd64 2.4.2-1 [82.6 kB]\n\rGet:9 http://archive.ubuntu.com/ubuntu xenial/main amd64 libsqlite3-0 amd64 3.11.0-1ubuntu1 [396 kB]\n\rGet:10 http://archive.ubuntu.com/ubuntu xenial/main amd64 libpython3.5-stdlib amd64 3.5.1-10 [2117 kB]\n\rGet:11 http://archive.ubuntu.com/ubuntu xenial/main amd64 python3.5 amd64 3.5.1-10 [159 kB]\n\rGet:12 http://archive.ubuntu.com/ubuntu xenial/main amd64 libpython3-stdlib amd64 3.5.1-3 [6818 B]\n\rGet:13 http://archive.ubuntu.com/ubuntu xenial/main amd64 dh-python all 2.20151103ubuntu1 [74.4 kB]\n\rGet:14 http://archive.ubuntu.com/ubuntu xenial/main amd64 python3 amd64 3.5.1-3 [8710 B]\n\rGet:15 http://archive.ubuntu.com/ubuntu xenial/main amd64 gcc-6-base amd64 6-20160319-0ubuntu1 [14.5 kB]\n\rGet:16 http://archive.ubuntu.com/ubuntu xenial/main amd64 libc-dev-bin amd64 2.23-0ubuntu2 [68.6 kB]\n\rGet:17 http://archive.ubuntu.com/ubuntu xenial/main amd64 linux-libc-dev amd64 4.4.0-16.32 [842 kB]\n\rGet:18 http://archive.ubuntu.com/ubuntu xenial/main amd64 libc6-dev amd64 2.23-0ubuntu2 [2083 kB]\n\rGet:19 http://archive.ubuntu.com/ubuntu xenial/main amd64 libexpat1-dev amd64 2.1.0-7 [115 kB]\n\rGet:20 http://archive.ubuntu.com/ubuntu xenial/main amd64 libpython3.5 amd64 3.5.1-10 [1360 kB]\n\rGet:21 http://archive.ubuntu.com/ubuntu xenial/main amd64 libpython3.5-dev amd64 3.5.1-10 [37.3 MB]\n\rGet:22 http://archive.ubuntu.com/ubuntu xenial/main amd64 libpython3-dev amd64 3.5.1-3 [6926 B]\n\rGet:23 http://archive.ubuntu.com/ubuntu xenial/main amd64 python3.5-dev amd64 3.5.1-10 [413 kB]\n\rGet:24 http://archive.ubuntu.com/ubuntu xenial/main amd64 python3-dev amd64 3.5.1-3 [1186 B]\n\rGet:25 http://archive.ubuntu.com/ubuntu xenial/main amd64 python3-pkg-resources all 20.3.1-1 [78.8 kB]\n\rGet:26 http://archive.ubuntu.com/ubuntu xenial/main amd64 python3-setuptools all 20.3.1-1 [88.1 kB]\n\rFetched 48.5 MB in 0s (0 B/s)\npy3versions -d\nPulling mqtt-paho-py3 \nCloning into '/tmp/adt-run.yy0Sf8/build.uM3/real-tree/examples/mosquitto/parts/mqtt-paho-py3/src'...\nfatal: unable to access 'https://git.eclipse.org/r/paho/org.eclipse.paho.mqtt.python/': Received HTTP code 403 from proxy after CONNECT\nCommand '['git', 'clone', '--depth', '1', '--recursive', '--branch',\n'v1.1', 'https://git.eclipse.org/r/paho/org.eclipse.paho.mqtt.python',\n'/tmp/adt-run.yy0Sf8/build.uM3/real-\ntree/examples/mosquitto/parts/mqtt-paho-py3/src']' returned non-zero\nexit status 128\n"}}}

Traceback (most recent call last):
  File "/tmp/adt-run.yy0Sf8/build.uM3/real-tree/examples_tests/test_mosquitto.py", line 27, in test_mosquitto
    self.build_snap(self.example_dir)
  File "/tmp/adt-run.yy0Sf8/build.uM3/real-tree/examples_tests/__init__.py", line 131, in build_snap
    stderr=subprocess.STDOUT)
  File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
    **kwargs).stdout
  File "/usr/lib/python3.5/subprocess.py", line 708, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/tmp/adt-run.yy0Sf8/build.uM3/real-tree/bin/snapcraft', 'snap']' returned non-zero exit status 1
@elopio
Member

elopio commented Apr 8, 2016

retest this please
@elopio
Add a test for the mosquitto example. 
LP: 1564181
This commit was signed with a verified signature.
@elopio elopio Leo Arias
GPG key ID: 852F630D0DA3C0E0 Learn about signing commits

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.67%
Details
1e15947
examples_tests/__init__.py
@@ -162,7 +162,7 @@ def install_snap(self, example_dir, snap_name, version):
def assert_command_in_snappy_testbed(self, command, expected_output):
if not config.get('skip-install', False):
output = self.run_command_in_snappy_testbed(command)
- self.assertEqual(output, expected_output)
+ self.assertEqual(expected_output, output)
@kyrofa

kyrofa Apr 8, 2016

Member

I've not been able to find documentation that unittest prefers one way or another. Should expected always come first?

@elopio

elopio Apr 8, 2016

Member

with testtools, the expected is first. When it fails, it prints like: expected: first argument, actual: second argument. I always get it wrong, but I try to update it when I see it fail with the wrong message.

with only unittest I think it doesn't matter, because it prints something like: first is not equal to second.

@kyrofa

kyrofa Apr 8, 2016

Member

Ah okay. Yeah I wish unittest would show you expected/actual-- I always have to look at the test itself to determine it.

@kyrofa
Member

kyrofa commented Apr 8, 2016

Looks good to me! 👍
@elopio
Merge branch 'master' into bug/1544249/mosquitto

Some checks were not successful

2 failing and 2 successful checks
@snappy-m-o
Examples tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.84%
Details
70ccf9e

@sergiusens sergiusens merged commit 48ac739 into snapcore:master Apr 8, 2016
2 of 4 checks passed

2 of 4 checks passed

Examples tests
Details
autopkgtest
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.84%
Details

@elopio elopio deleted the elopio:bug/1544249/mosquitto branch Jan 30, 2017

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@elopio @sergiusens
Add a test for the mosquitto example. (#418) 
LP: #1564181
f39f297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment