/snapcraft

Suggest a full clean if step clean is missing state. #421

Merged
merged 2 commits into from Apr 4, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kyrofa @elopio @sergiusens
@kyrofa
Member

kyrofa commented Apr 4, 2016

Currently if attempting to run a per-step clean on a tree made dirty by a version of Snapcraft that didn't support per-step cleaning, Snapcraft suggests trying to run that step again. This isn't possible since the step has already been run, so it actually requires a full clean. This PR resolves LP: #1561328 by updating the suggestions to reflect this fact.
@kyrofa
Suggest a full clean if step clean is missing state. 
Currently if attempting to run a per-step clean on a tree made
dirty by a version of Snapcraft that didn't support per-step
cleaning, Snapcraft suggests trying to run that step again. This
isn't possible since the step has already been run, so it actually
requires a full clean. This commit updates the suggestions to
reflect this fact.

LP: #1561328

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 15 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.635%
Details
3fc2416
@elopio
Member

elopio commented Apr 4, 2016

Thank you! 👍
@kyrofa
Merge branch 'master' into bugfix/1561328/step_cleaning_missing_state… 
…_message

All checks have passed

4 successful checks
@snappy-m-o
Examples tests — Success 15 tests run, 0 skipped, 0 failed.
Details
@snappy-m-o
autopkgtest — Success No test results found.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 95.613%
Details
69f0704

@sergiusens sergiusens merged commit 6ade343 into snapcore:master Apr 4, 2016
3 of 4 checks passed

3 of 4 checks passed

Examples tests Started
Details
autopkgtest Success No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.613%
Details

@kyrofa kyrofa deleted the kyrofa:bugfix/1561328/step_cleaning_missing_state_message branch Apr 13, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

@hglkrijger
stop pidof from spamming the logs (#421)
220d87c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment